Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Item] Dragonwrath, Tarecgosa's Rest #946

Closed
15 of 16 tasks
InDebt opened this issue Aug 20, 2024 · 13 comments
Closed
15 of 16 tasks

[Item] Dragonwrath, Tarecgosa's Rest #946

InDebt opened this issue Aug 20, 2024 · 13 comments

Comments

@InDebt
Copy link
Contributor

InDebt commented Aug 20, 2024

Important

With the approach of the next phase, the desire to accuratley simulate and gauge Dragonwrath, Tarecgosa's Rest will be higher and higher. This Staff is the newest legendary introduced with the Firelands raid and will be in high demand for every caster. Therefore, it's very desirebly to provide a high quality implementation for this item, as it has many class specific interactions. This issue shall be used to gather all information we can, as it's unlikely the staff will be available for testing on the upcoming PTR. Please contribute any old resources and references you have. Take the results of the simulations with the staff with bit of scepticism until we have larger testing and reference datasets.

Note

This issue will be constantly updated with the latest references and feedback gathered

General behaviour

  • When equiped the staff provides the ability to duplicate the casters damaging spells.
  • Direct damaging spells will be replicated as a direct copy of that same spell
  • Periodic damaging ticks will be replicated causing the exact same amount of damage as arcane damage through Wrath of Tarecgosa 1
    • As it's another spell, players will not benefit from talents here. A good exaple would be Shadow Orbs which can trigger from Shadow Word: Pain ticks. These will not be triggered by a tick replication from the staff.
  • The replicated spells from direct casts behave the same way a cast would that player's cast themselves. i.E. consuming procs and benefitting from the same modifiers. 1
  • Spells are replicated on damage. Causing spells with projectiles to be replicated on impact 2
  • Even though it is stated that the Staff has an internal cooldown, it seems to be around the 10ms visible through wowhead. 3
    • Procs occuring immediatly after another can be seen here 4 56s

Class specifics

  • There seem to be different proc chances for different classes as indicated by blizzard.

Furthermore, the proc chance is adjusted favorably for pet specs that derive a significant portion of their DPS from pets.
5

Proc Chances per Spec

Class Spec Proc Chance Reference
Druid Balance 8% 6 7 8
Mage Arcane 9.16% simc (4.3)
Mage Fire 8.0% 9
Mage Frost 9.16% simc (4.3)
Priest Discipline ? -
Priest Shadow 9% 10
Shaman Elemental 10.8% PTR - Sheet missing
Warlock Affliction ~10.5% 11
Warlock Demonology ~12.6% 11
Warlock Destruction ~11.6% 11

Class specific interactions

Shaman

  • Fulmination Will be replecated based on the initial casts damage calculations for Lightning Shield. 12 (56 seconds)
  • Flame Shock initial can be replicated, the dot duration is not affected.
  • Can overload procs be replicated
    • Yes. Overload procs can be replicated 13
  • Replicated spells do not proc overload
  • Can lightning shield procs be replicated

Mages

  • Flame Strike replicates the ticks as DoT ticks 1
    • Whole spell can be replicated. A second Flamestrike on the ground will not be placed.
  • Bast Wave will be replicated as another Blast Wave 1
  • If talented into Improved Flame Strike a replicated Baste Wave will cast another Flame Strike 1. There will be no 3rd Flamestrike.
  • Procs on Arcane Blast will also apply a debuf stack 1
  • Can Flame Orb / Frost Orb procs be replicated? We have conflicting statements
    • Flame Orb and Frost Orb are not replicated 1
    • Flame Orb and Frost Orb are replicated as direct spells 9
  • Pyro Cast and Dot Ticks are replicated 14 2m05
  • Final explosion of Living Bomb can be replicated

Shadow

  • Mind Sear replicates each tick as a cast 15 6m8s. Proc chance per target and way lower than single target spells.
  • MS and MB are replicated. In OG cata the replication spell was severly delayed after the initial hit. This allowed for orbs being procced again and the proc can consume those orbs 15 1m21s
  • We will have to see how large the delay of the procced spell will be on current version of wow
    • Delay is practically 0
  • SW:D will replicate and deal the damage feedback twice as well 16 03m30s
  • IMP:DP can not be replicated

Warlock

  • Hellfire is treated as a DoT similar to Flame Strike 17
  • How does Conflagrate interact with DTR? Is the initial damage used when calculating the immolate damage? As the proc might trigger when Immolate is not active on the target.
  • Havoc does not replicate duplicated spells

Balance

  • MF
    • MF initial can be replicated. The second damage event will not refresh the dot duration
    • Lunar Shower does not proc off the replicated damage tick
    • Clear casting can proc from the replicated damage
  • Starfire
    • Replicated starfires do interact with the Starfire Glyph
  • Hurricane ticks are replicated fully. Proc rate is based per target. Reported right now ~1%.
  • Mushrooms are replicated fully and also have a lower proc chance than single target spells
  • If a spell that takes you of eclipse procs DTR, the copied spells gain eclipse bonus

Open topics

In general the following information would be nice to gather additionaly:

  • Are there any spells that should not be replicated but would be expected to be based the outlined behaviour
    • Warlock's Immolation Aura does not seem to be replicated
  • Should spells and procs from enchants, trinket or other items be replicated
    • Anything that is a proc (Overload seems to be an exception) is not replicated
  • Should procs be replicated (i.E. can an elemental shaman's overloaded spell be replicated)
    • No procs are replicated, except their flagged with "Not a proc"

Implementation

Please provide any information you have, that is based on reliable evidence like videos, old combat log snippets, class forums or old elitist jerks threats. Private server information or memory can not be used here.

References

Footnotes

  1. https://www.wowhead.com/cata/item=71086/dragonwrath-tarecgosas-rest#comments:id=1492763 2 3 4 5 6 7

  2. https://web.archive.org/web/20120126094819/http://elitistjerks.com/f80/t125554-dragonwrath_tarecgosas_rest_warlock_specific_analysis/p4

  3. https://www.wowhead.com/cata/item=71086/dragonwrath-tarecgosas-rest#comments:id=1450301

  4. https://www.youtube.com/watch?v=fnoKFCLHkYw&t=55s

  5. https://web.archive.org/web/20110623014842/http://us.battle.net/wow/en/forum/topic/2674988056?page=1#15

  6. https://web.archive.org/web/20120620030834/http://elitistjerks.com/f73/t114017-balance_wrathcalcs/p14/#post2041883

  7. https://www.youtube.com/watch?v=TNpCovslvtI

  8. https://docs.google.com/spreadsheets/d/e/2PACX-1vTaCACFb7dqXpF2qwAZIAgXX-p2VTuJWqmyWXqaJ3c49FNWm61E9-unEdN3cn7YHevoGWWPmqkqJv6h/pubhtml

  9. https://web.archive.org/web/20120208065305/http://elitistjerks.com/f75/t110187-cataclysm_mage_simulators_formulators/p16/ 2

  10. https://docs.google.com/spreadsheets/d/e/2PACX-1vSzCde3Y9Cx4D_tFS3IhT4Iu0z6H1jfz_zE4L9pSmIHZ7pTYYlZtTQ9KgWJycCZ2ZcD9CayIQ0BLKgT/pubhtml

  11. https://docs.google.com/spreadsheets/d/12jnHZgMAYDTBmkeFjApaHL5yiiDlxXHYDbTXy2QCEBA/edit?gid=707775684#gid=707775684 2 3

  12. https://youtu.be/OkWBIBpf1xw?si=y-iY1y162m9FKo4h

  13. https://www.wowhead.com/cata/item=71086/dragonwrath-tarecgosas-rest#comments:id=1570599

  14. https://www.youtube.com/watch?v=5Of2uN0baDQ

  15. https://www.youtube.com/watch?v=TJLDHQL47AU 2

  16. https://www.youtube.com/watch?v=ErzB9phDrMU

  17. https://web.archive.org/web/20120124053831/http://elitistjerks.com/f80/t125554-dragonwrath_tarecgosas_rest_warlock_specific_analysis/

@stn-ms
Copy link
Member

stn-ms commented Sep 11, 2024

Some more info on Balance:

@1337LutZ
Copy link
Contributor

@InDebt
Copy link
Contributor Author

InDebt commented Sep 16, 2024

Weak evidence, but good to test; VPLC trinket being replicated

https://web.archive.org/web/20120809013459/http://elitistjerks.com/f80/t125554-dragonwrath_tarecgosas_rest_warlock_specific_analysis/p3/

Yeah - the video reference I posted for Balance PTR Proc rate testing also mentioned it. For now I have implmented it that way but I have not found any video evidence yet.

@Polynomix
Copy link
Contributor

Elemental ptr testing : #1114

@stn-ms
Copy link
Member

stn-ms commented Oct 21, 2024

According to our weekend PTR testing, Moonfire / Sunfire impact spells are indeed duplicated - I'll mark that as done.

Here's a link to the spreadsheet with all the data we've gathered: https://docs.google.com/spreadsheets/d/e/2PACX-1vTaCACFb7dqXpF2qwAZIAgXX-p2VTuJWqmyWXqaJ3c49FNWm61E9-unEdN3cn7YHevoGWWPmqkqJv6h/pubhtml

Apart from WM and Starfall, the proc rate appears to be higher than the currently reported 7.2%

@InDebt
Copy link
Contributor Author

InDebt commented Oct 21, 2024

Yes I can confirm they're replicated. The following interactions for them are noteworthy though.

  • Lunar Shower is not procced from the replicated MF
  • Clear Casting can proc from the replicated spell
  • The replicated spell does not affect the dot duration / pandemic
  • VPLC can procc off the replicated spell

@InDebt
Copy link
Contributor Author

InDebt commented Oct 21, 2024

@stn-ms Looking at the data 8% seems to be a nice approximation for the proc rate right now.

Regarding the shrooms. I think the proc rate is not estimated correctly. I've thought about it and DTR does not proc on cast but on damage dealt. So the actual shroom damage should proc the cast.

I've tested here https://classic.warcraftlogs.com/reports/qDn2L4C1w6TpXjR3#type=casts&boss=-3&difficulty=0&start=12672593&end=21260494&source=4

As you can see I've got 7 procs out of 446 detonate casts. Which is ~1.5% and way below the reported one.

Using this log as reference: https://classic.warcraftlogs.com/reports/F23Z4rTwLhMmKbyv#boss=0&difficulty=0&source=6&type=casts

Using the Mushroom casts, so assuming 1 shroom rolls per explosion once, invariant of targets hit, we get 40 / 895 = 4.46%.
Also seems too high. However. If we look at the damage dealt events (2784 and subtract rougly 120, 4 for each proc of DTR so 2660) we get 40 / 2660 = 1.5%. Which would perfectly match the observed proc rate on single target.

Therefore my hypothisis woudl be that AoE abilities have a reduced proc rate and proc per damage event.

@ssabbyccatt
Copy link

ssabbyccatt commented Oct 21, 2024

We have over 10k 3-shroom-explosions to make up the data. The fact that you got a lower proc chance is only because you only did 446 tests. When we were at only 446 tests, our proc chance was significantly different from what is recorded. That's why we did 10k+ tests per spell, to arrive at a number that is supported by data. The methodology is explained in the sheet; if you're trying to discern single shroom proc chance it is obviously not 8% because that's on a full 3-shroom explosion. Once we have finished analyzing our data, we will provide the proc % chance for a single shroom.

@Polynomix
Copy link
Contributor

Polynomix commented Oct 21, 2024

Therefore my hypothisis woudl be that AoE abilities have a reduced proc rate and proc per damage event.

I think it really depends on the ability. Shaman's Thunderstorm procs per cast on every target hit for example.

@InDebt
Copy link
Contributor Author

InDebt commented Oct 21, 2024

We have over 10k 3-shroom-explosions to make up the data. The fact that you got a lower proc chance is only because you only did 446 tests. When we were at only 446 tests, our proc chance was significantly different from what is recorded. That's why we did 10k+ tests per spell, to arrive at a number that is supported by data. The methodology is explained in the sheet; if you're trying to discern single shroom proc chance it is obviously not 8% because that's on a full 3-shroom explosion. Once we have finished analyzing our data, we will provide the proc % chance for a single shroom.

First of all, thanks for the feedback. I've noticed that my sample on WCL is useless as I did not keep myself infight. Thus kinda screwing proper log parsing on WCL. I've manually parsed the combat log in google sheets now and got 7 procs on 600 casts for a single shroom.

Really appreciate the effort by the way that went into collecting all that data. Would be nice if the data can support either a proc chance per shroom or a proc chance per target and shroom. For Mind Sear for example the current data we have suggests that the proc rate significantly increases with the amount of targets hit per tick.

@ssabbyccatt
Copy link

ssabbyccatt commented Oct 21, 2024

We have over 10k 3-shroom-explosions to make up the data. The fact that you got a lower proc chance is only because you only did 446 tests. When we were at only 446 tests, our proc chance was significantly different from what is recorded. That's why we did 10k+ tests per spell, to arrive at a number that is supported by data. The methodology is explained in the sheet; if you're trying to discern single shroom proc chance it is obviously not 8% because that's on a full 3-shroom explosion. Once we have finished analyzing our data, we will provide the proc % chance for a single shroom.

First of all, thanks for the feedback. I've noticed that my sample on WCL is useless as I did not keep myself infight. Thus kinda screwing proper log parsing on WCL. I've manually parsed the combat log in google sheets now and got 7 procs on 600 casts for a single shroom.

Really appreciate the effort by the way that went into collecting all that data. Would be nice if the data can support either a proc chance per shroom or a proc chance per target and shroom. For Mind Sear for example the current data we have suggests that the proc rate significantly increases with the amount of targets hit per tick.

We should be able to get proc rate per shroom data once we've had a chance to fully go through it. Should have that done later this week; our other TC is unavailable until Thursday iirc. Proc per target won't really matter for Shrooms, they actually fully dupe the entire shroom, functioning as if you just have a 4th/5th/6th mushroom up (relatedly, we have also confirmed no ICD at least for shrooms, we have at least 2 logs with 2 shroom explosion dupes within 0.001s of each other). And almost all of our logs are with melee attacks to stay in combat, so should be good data (and we've already identified and excluded the 10 times someone detonated with less than 3 mushrooms up, so all our data is exclusively 3-shroom detonations)

@stn-ms
Copy link
Member

stn-ms commented Oct 22, 2024

Yes I can confirm they're replicated. The following interactions for them are noteworthy though.

  • Lunar Shower is not procced from the replicated MF
  • Clear Casting can proc from the replicated spell
  • The replicated spell does not affect the dot duration / pandemic
  • VPLC can procc off the replicated spell

We tested Glyph of Starfire, duplicated Starfires do extend Moonfire/Sunfire, when there are 'extensions' left.

@InDebt InDebt closed this as completed Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants