From 022a66f55c522a9e9d7781bc902922a50588062e Mon Sep 17 00:00:00 2001 From: Kayla Glick Date: Fri, 29 Nov 2024 17:35:43 -0500 Subject: [PATCH] add ranged proc mask --- sim/core/flags.go | 20 ++++++++++++-------- sim/hunter/serpent_sting.go | 2 +- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/sim/core/flags.go b/sim/core/flags.go index 53c0811698..75847f504e 100644 --- a/sim/core/flags.go +++ b/sim/core/flags.go @@ -48,10 +48,13 @@ const ( ProcMaskRangedSpecial ProcMaskSpellDamage ProcMaskSpellHealing - ProcMaskSpellProc // Special mask for Spell procs that can trigger things (Can be used together with damage proc mask or alone) - ProcMaskMeleeProc // Special mask for Melee procs that can trigger things (Can be used together with damage proc mask or alone) - ProcMaskSpellDamageProc // Mask for procs triggering from spell damage procs like FT weapon and rogue poisons - ProcMaskMeleeDamageProc // Mask for procs (e.g. War Rune / Focuessed Attacks) triggering from melee damage procs + + ProcMaskMeleeProc // Special mask for Melee procs that can trigger things (Can be used together with damage proc mask or alone) + ProcMaskRangedProc // Special mask for Ranged procs that can trigger things (Can be used together with damage proc mask or alone) + ProcMaskSpellProc // Special mask for Spell procs that can trigger things (Can be used together with damage proc mask or alone) + ProcMaskMeleeDamageProc // Mask for procs (e.g. Art of War Rune Focuessed Attacks) triggering from melee damage procs + ProcMaskRangedDamageProc // Mask for procs triggering from ranged damage procs + ProcMaskSpellDamageProc // Mask for procs triggering from spell damage procs like FT weapon and rogue poisons ) @@ -77,11 +80,12 @@ const ( ProcMaskSpecial = ProcMaskMeleeOrRangedSpecial | ProcMaskSpellDamage - ProcMaskMeleeOrMeleeProc = ProcMaskMelee | ProcMaskMeleeProc - ProcMaskSpellOrSpellProc = ProcMaskSpellDamage | ProcMaskSpellProc + ProcMaskMeleeOrMeleeProc = ProcMaskMelee | ProcMaskMeleeProc + ProcMaskRangedOrRangedProc = ProcMaskRanged | ProcMaskRangedProc + ProcMaskSpellOrSpellProc = ProcMaskSpellDamage | ProcMaskSpellProc - ProcMaskProc = ProcMaskSpellProc | ProcMaskMeleeProc - ProcMaskDamageProc = ProcMaskSpellDamageProc | ProcMaskMeleeDamageProc // Mask for Fiery Weapon and Blazefury Medalion that trigger melee and spell procs + ProcMaskProc = ProcMaskMeleeProc | ProcMaskRangedProc | ProcMaskSpellProc + ProcMaskDamageProc = ProcMaskMeleeDamageProc | ProcMaskRangedDamageProc | ProcMaskSpellDamageProc // Mask for Fiery Weapon and Blazefury Medalion that trigger melee and spell procs ) // Possible outcomes of any hit/damage roll. diff --git a/sim/hunter/serpent_sting.go b/sim/hunter/serpent_sting.go index 91c6ddfa40..4010732742 100644 --- a/sim/hunter/serpent_sting.go +++ b/sim/hunter/serpent_sting.go @@ -85,7 +85,7 @@ func (hunter *Hunter) chimeraShotSerpentStingSpell(rank int) *core.Spell { SpellSchool: core.SpellSchoolNature, CastType: proto.CastType_CastTypeRanged, DefenseType: core.DefenseTypeRanged, - ProcMask: core.ProcMaskEmpty, + ProcMask: core.ProcMaskRangedProc | core.ProcMaskRangedDamageProc, Flags: core.SpellFlagMeleeMetrics | core.SpellFlagPassiveSpell, MissileSpeed: 24,