From cf00d39acdda2e1a2aad45332a82a4a03d6ef724 Mon Sep 17 00:00:00 2001 From: Saeyon <ethan_simpson@live.com> Date: Sat, 23 Nov 2024 10:59:06 -0800 Subject: [PATCH 1/2] changed damage formulas --- sim/rogue/eviscerate.go | 3 ++- sim/rogue/items_sets_pve.go | 8 ++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/sim/rogue/eviscerate.go b/sim/rogue/eviscerate.go index c2a8c6d46e..9e4ac402f6 100644 --- a/sim/rogue/eviscerate.go +++ b/sim/rogue/eviscerate.go @@ -65,8 +65,9 @@ func (rogue *Rogue) registerEviscerate() { }, DamageMultiplier: 1 + - []float64{0, 0.05, 0.10, 0.15}[rogue.Talents.ImprovedEviscerate] + []float64{0, 0.02, 0.04, 0.06}[rogue.Talents.Aggression], + DamageMultiplierAdditive: 1 + + []float64{0, 0.05, 0.10, 0.15}[rogue.Talents.ImprovedEviscerate], ThreatMultiplier: 1, BonusCoefficient: 1, diff --git a/sim/rogue/items_sets_pve.go b/sim/rogue/items_sets_pve.go index 7e925fce82..927b542e09 100644 --- a/sim/rogue/items_sets_pve.go +++ b/sim/rogue/items_sets_pve.go @@ -412,17 +412,17 @@ var ItemSetEmblemsofVeiledShadows = core.NewItemSet(core.ItemSet{ var ItemSetDeathdealersThrill = core.NewItemSet(core.ItemSet{ Name: "Deathdealer's Thrill", Bonuses: map[int32]core.ApplyEffect{ - // Increases Saber Slash damage by 20% + // Increases Saber Slash and Sinister Strike damage by 20% 2: func(agent core.Agent) { rogue := agent.(RogueAgent).GetRogue() rogue.RegisterAura(core.Aura{ Label: "S03 - Item - TAQ - Rogue - Damage 2P Bonus", OnInit: func(aura *core.Aura, sim *core.Simulation) { if rogue.HasRune(proto.RogueRune_RuneSaberSlash) { - rogue.SaberSlash.DamageMultiplier *= 1.20 - rogue.saberSlashTick.DamageMultiplier *= 1.20 + rogue.SaberSlash.DamageMultiplierAdditive += .2 + rogue.saberSlashTick.DamageMultiplierAdditive += .2 } - rogue.SinisterStrike.DamageMultiplier *= 1.20 + rogue.SinisterStrike.DamageMultiplierAdditive += .2 }, }) }, From f8ee328ce47d4e522171b6b0d87219479ba6e120 Mon Sep 17 00:00:00 2001 From: Saeyon <ethan_simpson@live.com> Date: Sat, 23 Nov 2024 11:02:01 -0800 Subject: [PATCH 2/2] aggression is also additive --- sim/rogue/eviscerate.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sim/rogue/eviscerate.go b/sim/rogue/eviscerate.go index 9e4ac402f6..646bbac26f 100644 --- a/sim/rogue/eviscerate.go +++ b/sim/rogue/eviscerate.go @@ -64,10 +64,9 @@ func (rogue *Rogue) registerEviscerate() { return rogue.ComboPoints() > 0 }, - DamageMultiplier: 1 + - []float64{0, 0.02, 0.04, 0.06}[rogue.Talents.Aggression], DamageMultiplierAdditive: 1 + - []float64{0, 0.05, 0.10, 0.15}[rogue.Talents.ImprovedEviscerate], + []float64{0, 0.05, 0.10, 0.15}[rogue.Talents.ImprovedEviscerate] + + []float64{0, 0.02, 0.04, 0.06}[rogue.Talents.Aggression], ThreatMultiplier: 1, BonusCoefficient: 1,