From 103da075b4e55054ae20323951c8bd1992ccafde Mon Sep 17 00:00:00 2001 From: Joosy Date: Mon, 13 Jan 2025 23:24:38 -0600 Subject: [PATCH 1/3] initial ele stone fix --- sim/core/consumes.go | 1 + sim/core/unit.go | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/sim/core/consumes.go b/sim/core/consumes.go index 302a9cc63d..9b23775f50 100644 --- a/sim/core/consumes.go +++ b/sim/core/consumes.go @@ -193,6 +193,7 @@ func addImbueStats(character *Character, imbue proto.WeaponImbue, isMh bool, sha character.AddStats(stats.Stats{ stats.MeleeCrit: 2 * CritRatingPerCritChance, }) + character.AddBonusRangedCritRating(-2.0) case proto.WeaponImbue_BlackfathomSharpeningStone: character.AddStats(stats.Stats{ stats.MeleeHit: 2 * MeleeHitRatingPerHitChance, diff --git a/sim/core/unit.go b/sim/core/unit.go index dc4ac3d9d9..fb1fb45557 100644 --- a/sim/core/unit.go +++ b/sim/core/unit.go @@ -410,6 +410,14 @@ func (unit *Unit) AddBonusRangedHitRating(amount float64) { }) } +func (unit *Unit) AddBonusRangedCritRating(amount float64) { + unit.OnSpellRegistered(func(spell *Spell) { + if spell.ProcMask.Matches(ProcMaskRanged) { + spell.BonusCritRating += amount + } + }) +} + func (unit *Unit) SetCurrentPowerBar(bar PowerBarType) { unit.currentPowerBar = bar } From e2aa7bde3b5e3d8a53582291cc0e916f6f781b11 Mon Sep 17 00:00:00 2001 From: Joosy Date: Mon, 13 Jan 2025 23:52:12 -0600 Subject: [PATCH 2/3] tests look expected - rogue also loses some damage --- sim/hunter/TestMM.results | 48 +++--- sim/hunter/TestSV.results | 228 +++++++++++++------------- sim/rogue/tank_rogue/TestTank.results | 74 ++++----- 3 files changed, 175 insertions(+), 175 deletions(-) diff --git a/sim/hunter/TestMM.results b/sim/hunter/TestMM.results index 94f0c16868..d8d6368695 100644 --- a/sim/hunter/TestMM.results +++ b/sim/hunter/TestMM.results @@ -421,96 +421,96 @@ dps_results: { dps_results: { key: "TestMM-Phase4-Lvl60-Settings-Dwarf-p4_ranged-Weave-p4_ranged-FullBuffs-P4-Consumes-LongMultiTarget" value: { - dps: 4680.01463 - tps: 5334.38396 + dps: 4646.24644 + tps: 5300.61577 hps: 17.71737 } } dps_results: { key: "TestMM-Phase4-Lvl60-Settings-Dwarf-p4_ranged-Weave-p4_ranged-FullBuffs-P4-Consumes-LongSingleTarget" value: { - dps: 2698.53775 - tps: 2731.21431 + dps: 2665.60409 + tps: 2698.28066 hps: 17.92142 } } dps_results: { key: "TestMM-Phase4-Lvl60-Settings-Dwarf-p4_ranged-Weave-p4_ranged-FullBuffs-P4-Consumes-ShortSingleTarget" value: { - dps: 2667.58565 - tps: 2698.90083 + dps: 2653.89565 + tps: 2685.21084 hps: 16.2045 } } dps_results: { key: "TestMM-Phase4-Lvl60-Settings-Dwarf-p4_ranged-Weave-p4_ranged-NoBuffs-P4-Consumes-LongMultiTarget" value: { - dps: 2431.2512 - tps: 3052.97629 + dps: 2408.17569 + tps: 3029.90079 hps: 9.23821 } } dps_results: { key: "TestMM-Phase4-Lvl60-Settings-Dwarf-p4_ranged-Weave-p4_ranged-NoBuffs-P4-Consumes-LongSingleTarget" value: { - dps: 1257.5962 - tps: 1288.68245 + dps: 1238.58545 + tps: 1269.6717 hps: 9.30873 } } dps_results: { key: "TestMM-Phase4-Lvl60-Settings-Dwarf-p4_ranged-Weave-p4_ranged-NoBuffs-P4-Consumes-ShortSingleTarget" value: { - dps: 1319.82215 - tps: 1343.55002 + dps: 1302.61803 + tps: 1326.34591 hps: 8.92667 } } dps_results: { key: "TestMM-Phase4-Lvl60-Settings-Orc-p4_ranged-Weave-p4_ranged-FullBuffs-P4-Consumes-LongMultiTarget" value: { - dps: 5051.80858 - tps: 5688.85924 + dps: 5004.96134 + tps: 5642.012 hps: 17.7196 } } dps_results: { key: "TestMM-Phase4-Lvl60-Settings-Orc-p4_ranged-Weave-p4_ranged-FullBuffs-P4-Consumes-LongSingleTarget" value: { - dps: 2868.17158 - tps: 2900.09936 + dps: 2824.23633 + tps: 2856.16411 hps: 17.66612 } } dps_results: { key: "TestMM-Phase4-Lvl60-Settings-Orc-p4_ranged-Weave-p4_ranged-FullBuffs-P4-Consumes-ShortSingleTarget" value: { - dps: 2938.84718 - tps: 2970.17843 + dps: 2893.32708 + tps: 2924.65833 hps: 15.94173 } } dps_results: { key: "TestMM-Phase4-Lvl60-Settings-Orc-p4_ranged-Weave-p4_ranged-NoBuffs-P4-Consumes-LongMultiTarget" value: { - dps: 2432.3139 - tps: 3027.07006 + dps: 2409.73439 + tps: 3004.49054 hps: 9.34711 } } dps_results: { key: "TestMM-Phase4-Lvl60-Settings-Orc-p4_ranged-Weave-p4_ranged-NoBuffs-P4-Consumes-LongSingleTarget" value: { - dps: 1241.14115 - tps: 1270.87896 + dps: 1221.34751 + tps: 1251.08532 hps: 9.36407 } } dps_results: { key: "TestMM-Phase4-Lvl60-Settings-Orc-p4_ranged-Weave-p4_ranged-NoBuffs-P4-Consumes-ShortSingleTarget" value: { - dps: 1337.00706 - tps: 1360.73493 + dps: 1314.25856 + tps: 1337.98643 hps: 8.74813 } } diff --git a/sim/hunter/TestSV.results b/sim/hunter/TestSV.results index 1094e8e912..b4bb0eacf3 100644 --- a/sim/hunter/TestSV.results +++ b/sim/hunter/TestSV.results @@ -198,7 +198,7 @@ stat_weights_results: { key: "TestSV-Phase4-Lvl60-StatWeights-Default" value: { weights: 0 - weights: 2.82757 + weights: 2.89414 weights: 0 weights: 0 weights: 0 @@ -216,7 +216,7 @@ stat_weights_results: { weights: 0 weights: 0.39647 weights: 0 - weights: 21.21761 + weights: 22.49626 weights: 0 weights: 0 weights: 0 @@ -224,7 +224,7 @@ stat_weights_results: { weights: 0 weights: 0 weights: 0 - weights: 0.44379 + weights: 0.43688 weights: 0 weights: 0 weights: 0 @@ -247,7 +247,7 @@ stat_weights_results: { key: "TestSV-Phase5-Lvl60-StatWeights-Default" value: { weights: 0 - weights: 3.24497 + weights: 3.10567 weights: 0 weights: 0 weights: 0 @@ -265,7 +265,7 @@ stat_weights_results: { weights: 0 weights: 0.50555 weights: 0 - weights: 27.07638 + weights: 28.26699 weights: 0 weights: 0 weights: 0 @@ -273,7 +273,7 @@ stat_weights_results: { weights: 0 weights: 0 weights: 0 - weights: 0.41386 + weights: 0.40686 weights: 0 weights: 0 weights: 0 @@ -407,405 +407,405 @@ dps_results: { dps_results: { key: "TestSV-Phase4-Lvl60-AllItems-BeastmasterArmor" value: { - dps: 1108.62529 - tps: 882.10353 + dps: 1098.86222 + tps: 872.34046 hps: 14.17231 } } dps_results: { key: "TestSV-Phase4-Lvl60-AllItems-BloodGuard'sChain" value: { - dps: 1244.72796 - tps: 992.53336 + dps: 1234.7259 + tps: 982.5313 hps: 14.17231 } } dps_results: { key: "TestSV-Phase4-Lvl60-AllItems-BloodlashBow-216516" value: { - dps: 1606.85657 - tps: 1613.91994 + dps: 1578.32437 + tps: 1585.38774 hps: 13.51585 } } dps_results: { key: "TestSV-Phase4-Lvl60-AllItems-DevilsaurEye-19991" value: { - dps: 3213.27592 - tps: 2825.17424 + dps: 3183.52144 + tps: 2795.41975 hps: 20.4684 } } dps_results: { key: "TestSV-Phase4-Lvl60-AllItems-DevilsaurTooth-19992" value: { - dps: 3187.12404 - tps: 2802.28393 + dps: 3157.68478 + tps: 2772.84467 hps: 20.4684 } } dps_results: { key: "TestSV-Phase4-Lvl60-AllItems-DreadHunter'sChain" value: { - dps: 1899.77808 - tps: 1636.85565 + dps: 1877.21263 + tps: 1614.30441 hps: 15.34389 } } dps_results: { key: "TestSV-Phase4-Lvl60-AllItems-GurubashiPitFighter'sBow-221450" value: { - dps: 1640.35797 - tps: 1647.42134 + dps: 1611.21978 + tps: 1618.28315 hps: 13.51585 } } dps_results: { key: "TestSV-Phase4-Lvl60-AllItems-Knight-Lieutenant'sChain" value: { - dps: 1244.72796 - tps: 992.53336 + dps: 1234.7259 + tps: 982.5313 hps: 14.17231 } } dps_results: { key: "TestSV-Phase4-Lvl60-AllItems-Maelstrom'sWrath-231320" value: { - dps: 3237.01395 - tps: 2852.87833 + dps: 3208.14444 + tps: 2824.00882 hps: 20.15517 } } dps_results: { key: "TestSV-Phase4-Lvl60-AllItems-SignetofBeasts-209823" value: { - dps: 3159.57977 - tps: 2784.51375 + dps: 3128.75551 + tps: 2753.77785 hps: 20.7632 } } dps_results: { key: "TestSV-Phase4-Lvl60-AllItems-ZandalarPredator'sBelt-231322" value: { - dps: 2886.18418 - tps: 2544.39142 + dps: 2861.36327 + tps: 2519.5705 hps: 19.87223 } } dps_results: { key: "TestSV-Phase4-Lvl60-AllItems-ZandalarPredator'sBracers-231323" value: { - dps: 3073.37628 - tps: 2703.58761 + dps: 3044.57123 + tps: 2674.78256 hps: 19.87223 } } dps_results: { key: "TestSV-Phase4-Lvl60-AllItems-ZandalarPredator'sMantle-231321" value: { - dps: 3116.93138 - tps: 2747.51823 + dps: 3089.86652 + tps: 2720.45337 hps: 19.87223 } } dps_results: { key: "TestSV-Phase4-Lvl60-Average-Default" value: { - dps: 3240.82233 - tps: 2856.97014 + dps: 3213.36765 + tps: 2829.539 hps: 20.17278 } } dps_results: { key: "TestSV-Phase4-Lvl60-Settings-Dwarf-p4_weave-Weave-p4_weave-FullBuffs-P4-Consumes-LongMultiTarget" value: { - dps: 4734.16901 - tps: 4772.50877 + dps: 4702.35119 + tps: 4740.76532 hps: 20.73445 } } dps_results: { key: "TestSV-Phase4-Lvl60-Settings-Dwarf-p4_weave-Weave-p4_weave-FullBuffs-P4-Consumes-LongSingleTarget" value: { - dps: 2996.97928 - tps: 2628.77088 + dps: 2969.3243 + tps: 2601.15309 hps: 20.62697 } } dps_results: { key: "TestSV-Phase4-Lvl60-Settings-Dwarf-p4_weave-Weave-p4_weave-FullBuffs-P4-Consumes-ShortSingleTarget" value: { - dps: 3041.22596 - tps: 2686.22531 + dps: 3001.78964 + tps: 2646.9749 hps: 20.03729 } } dps_results: { key: "TestSV-Phase4-Lvl60-Settings-Dwarf-p4_weave-Weave-p4_weave-NoBuffs-P4-Consumes-LongMultiTarget" value: { - dps: 3306.01954 - tps: 3565.88718 + dps: 3289.45572 + tps: 3549.53198 hps: 10.42193 } } dps_results: { key: "TestSV-Phase4-Lvl60-Settings-Dwarf-p4_weave-Weave-p4_weave-NoBuffs-P4-Consumes-LongSingleTarget" value: { - dps: 1517.98161 - tps: 1353.69711 + dps: 1505.96652 + tps: 1341.86616 hps: 10.30148 } } dps_results: { key: "TestSV-Phase4-Lvl60-Settings-Dwarf-p4_weave-Weave-p4_weave-NoBuffs-P4-Consumes-ShortSingleTarget" value: { - dps: 1510.76821 - tps: 1328.81466 + dps: 1495.34277 + tps: 1313.57795 hps: 10.61961 } } dps_results: { key: "TestSV-Phase4-Lvl60-Settings-Orc-p4_weave-Weave-p4_weave-FullBuffs-P4-Consumes-LongMultiTarget" value: { - dps: 5047.14236 - tps: 5076.96859 + dps: 5016.1643 + tps: 5045.99053 hps: 20.44579 } } dps_results: { key: "TestSV-Phase4-Lvl60-Settings-Orc-p4_weave-Weave-p4_weave-FullBuffs-P4-Consumes-LongSingleTarget" value: { - dps: 3228.49257 - tps: 2840.30554 + dps: 3203.50833 + tps: 2815.3213 hps: 20.51335 } } dps_results: { key: "TestSV-Phase4-Lvl60-Settings-Orc-p4_weave-Weave-p4_weave-FullBuffs-P4-Consumes-ShortSingleTarget" value: { - dps: 3292.64028 - tps: 2933.649 + dps: 3259.7443 + tps: 2900.75302 hps: 19.28493 } } dps_results: { key: "TestSV-Phase4-Lvl60-Settings-Orc-p4_weave-Weave-p4_weave-NoBuffs-P4-Consumes-LongMultiTarget" value: { - dps: 3296.14027 - tps: 3549.76953 + dps: 3280.69702 + tps: 3534.42487 hps: 10.54881 } } dps_results: { key: "TestSV-Phase4-Lvl60-Settings-Orc-p4_weave-Weave-p4_weave-NoBuffs-P4-Consumes-LongSingleTarget" value: { - dps: 1511.87796 - tps: 1345.95201 + dps: 1499.98183 + tps: 1334.14988 hps: 10.37136 } } dps_results: { key: "TestSV-Phase4-Lvl60-Settings-Orc-p4_weave-Weave-p4_weave-NoBuffs-P4-Consumes-ShortSingleTarget" value: { - dps: 1545.37175 - tps: 1362.50325 + dps: 1527.94234 + tps: 1345.18848 hps: 10.57364 } } dps_results: { key: "TestSV-Phase4-Lvl60-SwitchInFrontOfTarget-Default" value: { - dps: 3012.04121 - tps: 2700.04616 + dps: 2981.42232 + tps: 2669.47145 hps: 19.89102 } } dps_results: { key: "TestSV-Phase5-Lvl60-AllItems-BeastmasterArmor" value: { - dps: 1176.83581 - tps: 955.63333 + dps: 1167.91782 + tps: 946.71534 } } dps_results: { key: "TestSV-Phase5-Lvl60-AllItems-BloodGuard'sChain" value: { - dps: 1350.98456 - tps: 1037.4956 + dps: 1338.33738 + tps: 1024.89025 } } dps_results: { key: "TestSV-Phase5-Lvl60-AllItems-BloodlashBow-216516" value: { - dps: 3803.3957 - tps: 3150.24938 + dps: 3773.70901 + tps: 3120.56268 } } dps_results: { key: "TestSV-Phase5-Lvl60-AllItems-DevilsaurEye-19991" value: { - dps: 4176.36148 - tps: 3543.77744 + dps: 4145.634 + tps: 3513.09891 } } dps_results: { key: "TestSV-Phase5-Lvl60-AllItems-DevilsaurTooth-19992" value: { - dps: 4147.28382 - tps: 3519.30258 + dps: 4116.76363 + tps: 3488.83133 } } dps_results: { key: "TestSV-Phase5-Lvl60-AllItems-DreadHunter'sChain" value: { - dps: 1985.75179 - tps: 1623.11729 + dps: 1965.91738 + tps: 1603.37411 } } dps_results: { key: "TestSV-Phase5-Lvl60-AllItems-GurubashiPitFighter'sBow-221450" value: { - dps: 3840.51351 - tps: 3184.38884 + dps: 3810.37458 + tps: 3154.24991 } } dps_results: { key: "TestSV-Phase5-Lvl60-AllItems-Knight-Lieutenant'sChain" value: { - dps: 1350.98456 - tps: 1037.4956 + dps: 1338.33738 + tps: 1024.89025 } } dps_results: { key: "TestSV-Phase5-Lvl60-AllItems-Maelstrom'sWrath-231320" value: { - dps: 4162.32224 - tps: 3531.55933 + dps: 4129.85124 + tps: 3499.24742 } } dps_results: { key: "TestSV-Phase5-Lvl60-AllItems-SignetofBeasts-209823" value: { - dps: 4113.9317 - tps: 3490.74303 + dps: 4082.76052 + tps: 3459.72803 } } dps_results: { key: "TestSV-Phase5-Lvl60-AllItems-ZandalarPredator'sBelt-231322" value: { - dps: 3682.60767 - tps: 3139.41683 + dps: 3651.94389 + tps: 3108.75305 } } dps_results: { key: "TestSV-Phase5-Lvl60-AllItems-ZandalarPredator'sBracers-231323" value: { - dps: 3781.1203 - tps: 3380.05211 + dps: 3746.43054 + tps: 3345.38707 } } dps_results: { key: "TestSV-Phase5-Lvl60-AllItems-ZandalarPredator'sMantle-231321" value: { - dps: 3899.64412 - tps: 3379.61555 + dps: 3866.33096 + tps: 3346.34331 } } dps_results: { key: "TestSV-Phase5-Lvl60-Average-Default" value: { - dps: 4204.07636 - tps: 3572.1438 + dps: 4171.34043 + tps: 3539.45461 } } dps_results: { key: "TestSV-Phase5-Lvl60-Settings-Dwarf-p5_weave-Weave-p5_weave-FullBuffs-P4-Consumes-LongMultiTarget" value: { - dps: 4630.33335 - tps: 4511.17332 + dps: 4590.84499 + tps: 4471.68497 } } dps_results: { key: "TestSV-Phase5-Lvl60-Settings-Dwarf-p5_weave-Weave-p5_weave-FullBuffs-P4-Consumes-LongSingleTarget" value: { - dps: 4043.11997 - tps: 3409.18837 + dps: 4008.34894 + tps: 3374.54261 } } dps_results: { key: "TestSV-Phase5-Lvl60-Settings-Dwarf-p5_weave-Weave-p5_weave-FullBuffs-P4-Consumes-ShortSingleTarget" value: { - dps: 4085.2645 - tps: 3427.88308 + dps: 4043.65991 + tps: 3386.50027 } } dps_results: { key: "TestSV-Phase5-Lvl60-Settings-Dwarf-p5_weave-Weave-p5_weave-NoBuffs-P4-Consumes-LongMultiTarget" value: { - dps: 2043.42559 - tps: 2397.27234 + dps: 2021.92159 + tps: 2375.95523 } } dps_results: { key: "TestSV-Phase5-Lvl60-Settings-Dwarf-p5_weave-Weave-p5_weave-NoBuffs-P4-Consumes-LongSingleTarget" value: { - dps: 1771.71878 - tps: 1521.63319 + dps: 1752.02919 + tps: 1502.18811 } } dps_results: { key: "TestSV-Phase5-Lvl60-Settings-Dwarf-p5_weave-Weave-p5_weave-NoBuffs-P4-Consumes-ShortSingleTarget" value: { - dps: 1815.39482 - tps: 1544.66655 + dps: 1797.67678 + tps: 1527.86708 } } dps_results: { key: "TestSV-Phase5-Lvl60-Settings-Orc-p5_weave-Weave-p5_weave-FullBuffs-P4-Consumes-LongMultiTarget" value: { - dps: 4611.02953 - tps: 4500.42625 + dps: 4574.68286 + tps: 4464.07957 } } dps_results: { key: "TestSV-Phase5-Lvl60-Settings-Orc-p5_weave-Weave-p5_weave-FullBuffs-P4-Consumes-LongSingleTarget" value: { - dps: 4060.64207 - tps: 3433.12388 + dps: 4025.50482 + tps: 3398.17873 } } dps_results: { key: "TestSV-Phase5-Lvl60-Settings-Orc-p5_weave-Weave-p5_weave-FullBuffs-P4-Consumes-ShortSingleTarget" value: { - dps: 4104.19467 - tps: 3443.38179 + dps: 4062.59008 + tps: 3401.99897 } } dps_results: { key: "TestSV-Phase5-Lvl60-Settings-Orc-p5_weave-Weave-p5_weave-NoBuffs-P4-Consumes-LongMultiTarget" value: { - dps: 2037.90172 - tps: 2376.55553 + dps: 2015.82403 + tps: 2354.63577 } } dps_results: { key: "TestSV-Phase5-Lvl60-Settings-Orc-p5_weave-Weave-p5_weave-NoBuffs-P4-Consumes-LongSingleTarget" value: { - dps: 1765.3005 - tps: 1509.18122 + dps: 1746.09259 + tps: 1490.31525 } } dps_results: { key: "TestSV-Phase5-Lvl60-Settings-Orc-p5_weave-Weave-p5_weave-NoBuffs-P4-Consumes-ShortSingleTarget" value: { - dps: 1816.82301 - tps: 1550.95155 + dps: 1798.28183 + tps: 1533.33063 } } dps_results: { key: "TestSV-Phase5-Lvl60-SwitchInFrontOfTarget-Default" value: { - dps: 3780.7048 - tps: 3285.18218 + dps: 3749.6982 + tps: 3254.37717 } } diff --git a/sim/rogue/tank_rogue/TestTank.results b/sim/rogue/tank_rogue/TestTank.results index 7f6a57592f..215007e9dd 100644 --- a/sim/rogue/tank_rogue/TestTank.results +++ b/sim/rogue/tank_rogue/TestTank.results @@ -50,8 +50,8 @@ character_stats_results: { stat_weights_results: { key: "TestTank-Phase5-Lvl60-StatWeights-Default" value: { - weights: 0.66374 - weights: 0.87555 + weights: 0.66352 + weights: 0.9147 weights: 0 weights: 0 weights: 0 @@ -67,9 +67,9 @@ stat_weights_results: { weights: 0 weights: 0 weights: 0 - weights: 0.52469 - weights: 13.9991 - weights: 4.54917 + weights: 0.52452 + weights: 15.43785 + weights: 4.3053 weights: 0 weights: 0 weights: 0 @@ -99,112 +99,112 @@ stat_weights_results: { dps_results: { key: "TestTank-Phase5-Lvl60-AllItems-BloodCorruptedLeathers" value: { - dps: 1674.31862 - tps: 1275.59537 + dps: 1677.347 + tps: 1276.00825 } } dps_results: { key: "TestTank-Phase5-Lvl60-AllItems-DarkmantleArmor" value: { - dps: 643.69377 - tps: 560.41906 + dps: 642.23996 + tps: 558.35465 } } dps_results: { key: "TestTank-Phase5-Lvl60-Average-Default" value: { - dps: 1713.06761 - tps: 4084.59577 + dps: 1710.75654 + tps: 4070.65795 } } dps_results: { key: "TestTank-Phase5-Lvl60-Settings-Human-p5_saber-Basic-P5_Saber-FullBuffs-P4-Consumes-LongMultiTarget" value: { - dps: 1525.1758 - tps: 5832.30946 + dps: 1518.61731 + tps: 5777.2344 } } dps_results: { key: "TestTank-Phase5-Lvl60-Settings-Human-p5_saber-Basic-P5_Saber-FullBuffs-P4-Consumes-LongSingleTarget" value: { - dps: 1057.30699 - tps: 2843.97031 + dps: 1057.39009 + tps: 2837.02343 } } dps_results: { key: "TestTank-Phase5-Lvl60-Settings-Human-p5_saber-Basic-P5_Saber-FullBuffs-P4-Consumes-ShortSingleTarget" value: { - dps: 1119.34494 - tps: 2888.83459 + dps: 1107.42986 + tps: 2843.12428 } } dps_results: { key: "TestTank-Phase5-Lvl60-Settings-Human-p5_saber-Basic-P5_Saber-NoBuffs-P4-Consumes-LongMultiTarget" value: { - dps: 594.37063 - tps: 2260.03503 + dps: 591.7018 + tps: 2248.17081 } } dps_results: { key: "TestTank-Phase5-Lvl60-Settings-Human-p5_saber-Basic-P5_Saber-NoBuffs-P4-Consumes-LongSingleTarget" value: { - dps: 415.7835 - tps: 1152.41774 + dps: 414.55231 + tps: 1146.61817 } } dps_results: { key: "TestTank-Phase5-Lvl60-Settings-Human-p5_saber-Basic-P5_Saber-NoBuffs-P4-Consumes-ShortSingleTarget" value: { - dps: 435.48286 - tps: 1144.895 + dps: 433.41998 + tps: 1134.74444 } } dps_results: { key: "TestTank-Phase5-Lvl60-Settings-Orc-p5_saber-Basic-P5_Saber-FullBuffs-P4-Consumes-LongMultiTarget" value: { - dps: 1566.46856 - tps: 5934.05721 + dps: 1555.26266 + tps: 5891.75228 } } dps_results: { key: "TestTank-Phase5-Lvl60-Settings-Orc-p5_saber-Basic-P5_Saber-FullBuffs-P4-Consumes-LongSingleTarget" value: { - dps: 1074.41858 - tps: 2879.17613 + dps: 1069.86561 + tps: 2858.72852 } } dps_results: { key: "TestTank-Phase5-Lvl60-Settings-Orc-p5_saber-Basic-P5_Saber-FullBuffs-P4-Consumes-ShortSingleTarget" value: { - dps: 1181.78862 - tps: 3028.54089 + dps: 1173.42845 + tps: 2978.10992 } } dps_results: { key: "TestTank-Phase5-Lvl60-Settings-Orc-p5_saber-Basic-P5_Saber-NoBuffs-P4-Consumes-LongMultiTarget" value: { - dps: 616.55297 - tps: 2303.69321 + dps: 613.18565 + tps: 2291.1135 } } dps_results: { key: "TestTank-Phase5-Lvl60-Settings-Orc-p5_saber-Basic-P5_Saber-NoBuffs-P4-Consumes-LongSingleTarget" value: { - dps: 428.89983 - tps: 1177.02519 + dps: 426.86493 + tps: 1165.68074 } } dps_results: { key: "TestTank-Phase5-Lvl60-Settings-Orc-p5_saber-Basic-P5_Saber-NoBuffs-P4-Consumes-ShortSingleTarget" value: { - dps: 466.10617 - tps: 1209.37682 + dps: 464.67513 + tps: 1199.81265 } } dps_results: { key: "TestTank-Phase5-Lvl60-SwitchInFrontOfTarget-Default" value: { - dps: 1721.7664 - tps: 4124.66069 + dps: 1712.75509 + tps: 4087.31127 } } From e4fb471ebf6f257c7b8ef36eb2dbf2536da25da7 Mon Sep 17 00:00:00 2001 From: Joosy Date: Tue, 14 Jan 2025 00:12:08 -0600 Subject: [PATCH 3/3] belated ranged fixes to slaying enchants --- sim/common/vanilla/enchant_effects.go | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/sim/common/vanilla/enchant_effects.go b/sim/common/vanilla/enchant_effects.go index 98b75a28d1..ae256972da 100644 --- a/sim/common/vanilla/enchant_effects.go +++ b/sim/common/vanilla/enchant_effects.go @@ -96,6 +96,10 @@ func init() { w.BaseDamageMin += 2 w.BaseDamageMax += 2 + + w = character.AutoAttacks.Ranged() + w.BaseDamageMin += 2 + w.BaseDamageMax += 2 } }) @@ -189,6 +193,10 @@ func init() { w.BaseDamageMin += 6 w.BaseDamageMax += 6 + + w = character.AutoAttacks.Ranged() + w.BaseDamageMin += 6 + w.BaseDamageMax += 6 } }) @@ -204,6 +212,10 @@ func init() { w.BaseDamageMin += 6 w.BaseDamageMax += 6 + + w = character.AutoAttacks.Ranged() + w.BaseDamageMin += 6 + w.BaseDamageMax += 6 } })