Protection Paladin Implementation

[wsphillips]

This issue is a tracker for all the talents, runes, abilities, and items/item sets associated with the Protection Paladin sim I have been working on. I will keep the list updated with links to PRs as they get submitted. Each item will be checked off when it is reviewed and merged.

UI Auras/Options

• Blessing of Sanctuary Prot Paladin: Blessing of Sanctuary + Improved Sanctuary #1071
• Righteous Fury Prot Paladin: Righteous fury + Hand of Reckoning #1064
• Forbearance Prot Paladin: Malleable Protection rune + Divine Protection + Forbearance #1048

Abilities

• Holy Shield Prot Paladin: Holy shield #1031
• Shield of Righteousness Prot Paladin: Shield of Righteousness #1028
• Divine Protection (MP) Prot Paladin: Malleable Protection rune + Divine Protection + Forbearance #1048
• Avenger's Shield Prot Paladin: Avenger's shield #1038
• Lay on Hands Prot Paladin: Lay on Hands + Improved Lay On Hands #1080
• Hammer of the Righteous Paladin: Correct HotR values #1036

Talents

• Shield Specialization/Anticipation Protection Paladin: Correct Shield Specialization/Anticipation #1027
• Redoubt Prot Paladin: Redoubt #1029
• Reckoning Prot Paladin: Reckoning #1030
• Improved Righteous Fury Prot Paladin: Righteous fury + Hand of Reckoning #1064
• Improved Lay on Hands Prot Paladin: Lay on Hands + Improved Lay On Hands #1080

Runes

• Aegis Prot Paladin: Aegis rune #1049
• Malleable Protection Prot Paladin: Malleable Protection rune + Divine Protection + Forbearance #1048
• Improved Sanctuary Prot Paladin: Blessing of Sanctuary + Improved Sanctuary #1071
• Hand of Reckoning (passive effects) Prot Paladin: Righteous fury + Hand of Reckoning #1064

Item Sets

• T1/T2 Item set bonuses Prot Paladin: Tier 1 + 2 item sets #1051

Items

• Libram of Avengement / Libram of the Devoted Prot Paladin: Libram of the Devoted + Libram of Avengement #1066

Core

• Correction to SBV Multiplier
  Shield Block Value Multiplier only applies to SBV gained through flat bonuses #1025
  Bug fix: Defer calculation of Block Value's strength dependency and add Shaman SBV from strength #1077

Finalization

• Update APLs, gear sets, default consumes/buffs and EP weights Protection Paladin: Preset updates and release tag #1112

[martijngonlag]

@wsphillips this is great, thank you for implementing this, I have been looking forward to having access to this!

As I am starting to use this, I had a couple of questions -- my apologies in advance if this is not the right place to raise these.

1. Does this consider the Truthbearer proc?
2. Is it possible to include Iron Counterweight as an enchant for Truthbearer? A fellow guildie who has the weapon informed me that you can apply a 2h enchant on it, and it will remain on when you swap to 1h, essentially reducing it's speed to 1.45 before the proc.

[wsphillips]

I'm currently doing a final pass on the presets/EP weights/etc which will include flagging the prot sim as live. But until that PR gets merged you can already access the ostensibly complete sim by navigating to it directly: https://wowsims.github.io/sod/protection_paladin/

I haven't touched Truthbearer (whoever was working on the shockadin spec did). The proc effect is in the sim, but the proc rate has a placeholder value (currently 2ppm) that will likely need adjusting when we have more testing data.

I'm hesitant to hard code 2H enchants on Truthbearer--that sounds like something that's unintended and may get hotfixed. If you want to see how Iron Counterweight would affect your own sims, just manually add a 3% weapon speed bonus by clicking on the +/- in the stats panel: