Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new stat for +Weapon Damage #1160

Closed
3 tasks
kayla-glick opened this issue Nov 17, 2024 · 0 comments
Closed
3 tasks

Create a new stat for +Weapon Damage #1160

kayla-glick opened this issue Nov 17, 2024 · 0 comments

Comments

@kayla-glick
Copy link
Collaborator

A select few items had a + X Weapon Damage effect in Vanilla. In SoD this number has drastically increased. Right now we track this as a Pseudostat, meaning each item must be implemented manually rather than being parsed from tooltips and stored in the database. This stat is functionally the Physical version of the various School Power stats, so we should consider just creating a proper stat for it and parsing it in the database.

  • Create a new stat PhysicalPower for tracking this stat
  • Parse the stat from wowhead tooltips like we do other school powers
  • Remove manual implementations of the pseudostat and the pseudostat altogether
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant