Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thorns/Damage shield is not correct in the results tab. #1208

Closed
shaugen opened this issue Jan 6, 2025 · 4 comments
Closed

Thorns/Damage shield is not correct in the results tab. #1208

shaugen opened this issue Jan 6, 2025 · 4 comments
Labels
bug Something isn't working

Comments

@shaugen
Copy link

shaugen commented Jan 6, 2025

Describe the bug
The Damage shield (Thorns) from various sources is not correct in the results tab.
I have equipped several items that give Thorns (or Damage shield as you call them), and 4 armor kits with 20 thorns each.
In the results tab, only 1 Armor kit is showing up, no matter how many I add, or no matter what other gear items with this effect is added.

It does 22 dmg (due to gladiator stance providing 10% extra), so at least that is correct.
But it should do way more, and give double threat according to tooltip.
Double threat is also bugged. It gives same threat as dmg given at the moment

To Reproduce
Check the following link and see for yourself.

Sim Links and Screenshots
https://wowsims.github.io/sod/tank_warrior/#eJzj4nZgnMHEuIGJcQcjoxNLAFMEoxWDFZMAoxCD1Ct2LraAnMTK1CIBJgkbBU6ttYxc3AKHF/FJXLDWeNIuxcUisK2fDyh0ECjUba0xZbcXkNP2jVeix1pjxUcpIGfKAj6Jh9YaZ39LAjnb+/kk7vJp7GkHyXydAJZ5f1qCi0NgRz+fxu0XINO/QIQnn5MAcj5DOA+nSQLVtC7i09jbLA1ktQFZG1pkgNaf/M4LJDuW8HGxC2zexifxhg/IvbMJRN5ewWfEfImRweoZC9cDJoZRQFMg1DDig/gVE4MT8wpGRi8FA1NjIwMDIwNjAyNdA2NdUwMjY1NDQ2MDkJihkalhAFcSQ1aqBDOXMBeHFBsXCwcwgSuxc7FyMesaFgvJcDBKSXDxKnFzcRoBBTm2RWmwS8EYQjxSXFIcXGwcX3cxarAIKUjJcQlo8XGwCTEVMYCM4mIyNpXi4uLgOHaUUYFRg7PgBOMPJsaT0MjhcLgIZVk63GBinMXIpMC2iYlFismCRekAMydEKs5BEMLQc5CcNRMETtpbQkQu2CumgcE1e6MJzBw3mniFOHxSy1JzFMwMJOy1Blk20+h0oIo5amspMkdA6j913AEEhmCyYLmDZWb+h9aTIVftHaEyDhGMAP/JfwA=

@kayla-glick kayla-glick added the bug Something isn't working label Jan 11, 2025
@kayla-glick
Copy link
Collaborator

hey @shaugen 👋 it looks like this was just an oversight with how the enchant was coded and didn't account for having multiple. I'm working on a fix but I'm curious if you know whether multiple count as separate hits in game or if they combine for one larger hit? I'm also curious how that works with Thorns from Druids

@kayla-glick
Copy link
Collaborator

This should be fixed now. Each kit will deal an additional hit whens truck
image

@shaugen
Copy link
Author

shaugen commented Jan 12, 2025

hey @shaugen 👋 it looks like this was just an oversight with how the enchant was coded and didn't account for having multiple. I'm working on a fix but I'm curious if you know whether multiple count as separate hits in game or if they combine for one larger hit? I'm also curious how that works with Thorns from Druids

They don't seem to be showing in the game combat log at all right now. None of the thorns are showing actually. Hopefully it gets added soon so we can see it in the dps meters etc.

Thanks for fixing this btw!

@shaugen
Copy link
Author

shaugen commented Jan 12, 2025

I ran it again now, and it seems to have a "miss" chance?
I don't think it can miss, the thorns effect. (Not entirely sure tho)
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants