[RUNE] Soul of the Toxicologist

[KegRodeoClown]

Describe the bug
The rune does not modify damage of poisons or envenoms

To Reproduce
Steps to reproduce the behavior:

1. Go to 'shoulder slot'
2. Click on 'Shoulder Rune'
3. Scroll down to 'Soul of the Toxicologist'
4. Does not modify poison damage

Expected behavior
Increase crit damage of Envenom and Poisons.

[kayla-glick]

Nice find @KegRodeoClown! Looks like my code editor autocompleted to the hunter Toxinologist rune so it wasn't applying the effect to the Rogue Toxicologist one. Pushing up a fix for it

[kayla-glick]

Increase crit damage of Envenom and Poisons.

Does this bonus actually increase Envenom's crit damage though? The wowhead spell data doesn't mention it at all and our code doesn't include Envenom at the moment. It should be buffing poisons correctly now as long as you don't already have the T1 4pc equipped

[KegRodeoClown]

You’re correct on the Envenom portion, that’s my mistake. As far as poisons, it doesn’t seem to be increasing the poison damage. I’m not home currently so I can’t send the sim, but whether the shoulder rune is selected or not, the damage doesn’t appear to be applied. There is no DPS increase showing. I can look more into it later and give better details.

[kayla-glick]

@KegRodeoClown it might be because you already had the T1 4pc set bonus equipped? When I went to test I used the Mutilate build from our sim spreadsheet and it used 4p Core Forged T2 with the effect. Zirene stated that shoulder runes aren't meant to stack with their original sets so that's what we have it doing in the sim

[kayla-glick]

Oh maybe mutilate doesn't 🤔 not sure which link I used I guess.

But I opened this sim and see 6828 dps, then add Toxicologist and it goes up to 6989 dps

[KegRodeoClown]

@KegRodeoClown it might be because you already had the T1 4pc set bonus equipped? When I went to test I used the Mutilate build from our sim spreadsheet and it used 4p Core Forged T2 with the effect. Zirene stated that shoulder runes aren't meant to stack with their original sets so that's what we have it doing in the sim

Nah that’s not it, I had t3/t2.5 on the sim with soul of toxicology. It’s working as intended now. Envenom does not benefit from the Toxicology rune, so it should be good now! Thank you! 😊