Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port item sets by ID from Cata then update crafted item set bonuses #940

Closed
ericbtaylorjr opened this issue Jul 27, 2024 · 3 comments
Closed
Labels
bug Something isn't working enhancement New feature or request

Comments

@ericbtaylorjr
Copy link

Describe the bug
When equipping the 2-piece of Devilcore, the +10 fire resistance bonus is not being added to the stats listing in bottom left sheet.

To Reproduce
Steps to reproduce the behavior:

  1. Add both Devilcore pieces.
  2. View fire resistance value in stat module.
  3. Remove one devilcore piece to break set.
  4. Observe the +10 set bonus was not being applied.

Expected behavior
+10 fire resist stat bonus to be presented in state panel properly.

Sim Links and Screenshots
Sim Link (Rogue)

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser: Chrome
  • Version 126
@kayla-glick
Copy link
Collaborator

For whatever dev takes a look at this, because a lot of the updated item sets have the same name we need to port setting up sets by set ID from the Cata site in order to properly support them. We then need to do a full pass at all of the crafted sets to make sure both versions are included

@kayla-glick
Copy link
Collaborator

Oops didn't mean to close

@kayla-glick kayla-glick reopened this Jul 28, 2024
@kayla-glick kayla-glick changed the title Devilcore Set Bonus not adding to Fire Resistance value. Port item sets by ID from Cata then update crafted item set bonuses Jul 28, 2024
@kayla-glick kayla-glick added bug Something isn't working enhancement New feature or request labels Jul 28, 2024
@kayla-glick
Copy link
Collaborator

Pushed up an update that adds item set IDs and updates the phase 4 crafted set bonuses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants