Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap Button is setting the Rotation to an APL #3959

Closed
transphenomenal opened this issue Oct 28, 2023 · 1 comment · Fixed by #4088
Closed

Swap Button is setting the Rotation to an APL #3959

transphenomenal opened this issue Oct 28, 2023 · 1 comment · Fixed by #4088
Labels
UI/UX Anything to do with the UI/UX of the sim.

Comments

@transphenomenal
Copy link

Describe the bug
The Swap Button is changing the Hunter (not sure about other classes) rotation from Simple Default to an APL rotation. This change happens even if you have only done a single simulation and there is nothing to swap to.

To Reproduce
Steps to reproduce the behavior:

  1. As a Hunter select the Simple Default rotation.
  2. Simulate a gearset.
  3. Save as Reference.
  4. Press Swap.

Expected behavior
Rotation should not be changing.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Firefox release 119.0 (64-bit)
@Tharre Tharre added the UI/UX Anything to do with the UI/UX of the sim. label Nov 9, 2023
@jimmyt857
Copy link
Contributor

This is a tricky one... it's because the Simple rotation is actually just a UI convenience which generates an APL rotation, and the resulting config sent to the sim is what we store internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/UX Anything to do with the UI/UX of the sim.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants