Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rogue] Hemorrhage Debuff doesn't seem to get applied at all. #4015

Closed
Skurrio opened this issue Nov 7, 2023 · 4 comments
Closed

[Rogue] Hemorrhage Debuff doesn't seem to get applied at all. #4015

Skurrio opened this issue Nov 7, 2023 · 4 comments
Labels

Comments

@Skurrio
Copy link

Skurrio commented Nov 7, 2023

Describe the bug
Hemorrhage should increase the Damage of the next 10 physical Attacks by 75. Currently this Debuff is neither visible, trackable nor does it seem to increase the Damage of physical Attacks at all.

To Reproduce
Steps to reproduce the behavior:

  1. Run Sim with only Autos
  2. Run Sim with only Autos and Hemorrhage
  3. Compare DPS from Autos
  4. See that Hermorrhage didn't increased DPS from Autos

Expected behavior
Hemorrhage should apply 10 Stacks of the Hemorrhage Debuff which are used by every physical Attack hitting the Target and increasing the Damage of said Attack by 75 (105 with Glyph).

Sim Links and Screenshots
Sim with only Autos: https://wowsims.github.io/wotlk/rogue/#eJzjEudgMmDKYCxgamBkXMHIuIOR8QIj4wtGRidJBSYLRgfGCMYKRqBUByPjArCCDUyMQgxSb1mbGNkCchIrU4s4OAXYpM4zcvELbJnALPFSVolt22GmrTuZuDgFTnYzKzGDmDwC24ByD2RhvLtTmSWmykB4/AKbgHI/gPpWnmR6BBTgFdiyilmiVU6JBSjNwCUg8LmbWWKKjBL73p1MYBF+gck9zEqc1/4zAXUAEVBgK9CI90AjgPJ7wWauB+r5BBQAGvgI7JYNq4BuATEZwBAo0AN1HKfA3m6oHKfAWqioEj8wXFgCWCJYElgqQL5fxPSViesAE8MooAgIGZCqo4qdg1GCCZj4osS42BSYNJg8WKV4BIBCBhOYXc+eOWPbxahtqGtgYGpkYGpgYAxEuqYGRkaGBkZAjjGQYWRobGpgCJQ0NjQyNXzEyMNx8zyTwMXzTBLHnzK9YGT5wMg+i5HhEBOTBPMJphOMF4D4FiPDLCaGm9DYVnNQmsfMCWY2pDkIQgRFHCQhjAv2ljCGomZM/6GvGk/sjd4xVXEGJJYkZ5SnFmUrBEtwaNE46Wh0OlDDmIaTRwiYE0wVe8gB4GBuEHroMJNx1kwQ2GnvCJF5YR8Ezpy2XNcXF9h+sj/8VQMYEX/tiTW5WmSd+8OqLfZvAnfItb6+iEPfB3uI+d/s5VtfA1V+tQfpEln33R5Euj98ZQ+O/Zj3RNs72ICQAdhjrewOkABmdiCkIwqanT8Q7WcAS3W+9A==

Sim with Autos and Hemorrhage:
https://wowsims.github.io/wotlk/rogue/#eJzjEudgMmDKYCxgamBkXMHIuIOR8QIj4wtGRidJBSYLRgfGCMYKRqBUByPjArCCDUyMQgxSP1mbGNkCchIrU4s4OAXYpM4zcvELbJnALPFSVolt22GmrTuZuDgFTnYzKzGDmDwC24ByD2RhvLtTmSWmykB4/AKbgHI/gPpWnmR6BBTgFdiyilmiVU6JBSjNwCUg8LmbWWKKjBL73p1MYBF+gck9zEqc1/4zAXUAEVBgK9CI90AjgPJ7wWauB+r5BBQAGggykwHomg2rgK6BcMDcHqjjOAX2dkNlOAXWQkWV+IHhwhLAEsGSwFIB8v0ipq9MXAeYGEYBRUDIgFQdVewcjBJMwMQXJcbFpsCkweTBKsUjABQymMDsevbMGdsuRm1DXQMDUyMDUwMDYyDSNTUwMjI0MAJyjIEMI0NjUwNDoKSxoZGp4SNGHo6b55kELp5nkjj+lOkFI8sHRvZZjAyHmPgkmIW4pDik2LhYOKb8YTrBdILxAhDfYmSYxcRwExrzag5K85g5wcyGNAdBiKCIgySEccHeEsZQ1IzpP/RV44m90TumKs6AxJLkjPLUomyFYAkOLRonI41OB2oY03DyCAFzgqliDzkAHMwNQg8dZjLOmgkCO+0dITIv7IPAGdWW6/riAttP9oe/agAj4q89sSZXi6xzf1i1xf5N4A651tcXcej7YA8x/5u9fOtroMqv9iBdIuu+24NI94ev7MGxH/OeaHsHGxAyAHusld0BEsDMDoR0REGz9gei/QwAobPBEg==

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Brave
  • Version 1.59.124

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@Tharre Tharre added the Rogue label Nov 9, 2023
@vigo2 vigo2 reopened this Nov 22, 2023
@vigo2
Copy link
Contributor

vigo2 commented Nov 22, 2023

The hemorrhage debuff was explicitly disabled for non-raid sims, since its contribution to personal DPS can't be modelled sensibly. See the discussion around https://discord.com/channels/891730968493305867/944495169657524255/1079892138243915847.

@jarveson
Copy link
Contributor

ill revert it then as its intended

@Skurrio
Copy link
Author

Skurrio commented Nov 22, 2023

Could you implement the Option to turn it on and off and have it deactivated by default?

@vigo2
Copy link
Contributor

vigo2 commented Nov 24, 2023

Thank you @jarveson. There's a new issue to implement that feature, Skurrio (#4060), maybe I'll get around doing this over the weekend.

@vigo2 vigo2 closed this as completed Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants