Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blinkstrike issues #597

Closed
lologarithm opened this issue Aug 11, 2022 · 3 comments
Closed

Blinkstrike issues #597

lologarithm opened this issue Aug 11, 2022 · 3 comments

Comments

@lologarithm
Copy link
Contributor

lologarithm commented Aug 11, 2022 •
edited
Loading

With 2x blinkstrikes a nil pointer error is thrown.

https://wowsims.github.io/wotlk/deathknight/#eJztUk0oRFEUft+ZZ7x5mrrYXEqNt5CUuvNer1jNY2ujbCxZkIWFZMPGNDaShZIMUoqFkrKwmLJQfmJIZjEo4y9/TUpZSFLkvnlkaTMLC1+30/n57vlu5x69QiNBXehBFFgEVoAUkAVeQSmiRhYiAQetkjCcI5Qo5QsFMfibu9v7O3q1ANPL96EzdvAOfnhBhn97g17WoKts6dnNTwwR33HzmTXIowfZdYx4IkOGz6WVslVJSMow4BFcThFLfIBvySQUvZjtjRI/WfYZhV5ZkT1SD/gJNZZ4Ab9fIik3dgaeldxvOZXNPrp2/ty10ZyNZSDv3D6DX875vrwr6cknr5Ohy4EE69Cstqo1u6T8Iy8YUDVwekOZ7mfgcqPkHgWLvdpThCOEEVSZlrCFEHatZUpr2cKyTVNYIiwLQlhWWIQtO3wNrs2kiU2miT/eUSiepur4EYmpI8pCfULhNJRTKMa4L5BrH+10PCFn0CmbnnKRjNR70qlIZWcOxxHzhkItnP7sn/c5+egSTW790qcpLzouvBkPbzoNXwmnDZ+aFYTa
@lologarithm lologarithm changed the title Blinkstrike (double?) causes crash Blinkstrike issues Aug 11, 2022
@lologarithm
Copy link
Contributor Author

lologarithm commented Aug 11, 2022 •
edited
Loading

Oh, duration variation is > base duration. Negative time could be causing the issue with the infinite loop with single BS. Double BS still causes nil pointer error though

@jimmyt857
Copy link
Contributor

Note that if we fix this, should consider backporting it to the TBC sim, as it was reported there too: wowsims/tbc#1084

@jimmyt857
Copy link
Contributor

Blinkstrike is no longer included in the wotlk sim so this bug is irrelevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lologarithm @jimmyt857