Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear Used CSS button in Divi notice results in white screen #6736

Open
webtrainingwheels opened this issue Jun 22, 2024 · 15 comments · May be fixed by #7227
Open

Clear Used CSS button in Divi notice results in white screen #6736

webtrainingwheels opened this issue Jun 22, 2024 · 15 comments · May be fixed by #7227
Assignees
Labels
3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting module: remove unused css priority: low Issues that can wait severity: major Feature is not working as expected and no work around available type: bug Indicates an unexpected problem or unintended behavior
Milestone

Comments

@webtrainingwheels
Copy link

webtrainingwheels commented Jun 22, 2024

Before submitting an issue please check that you’ve completed the following steps:

  • 3.16.1
  • Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug
When using Remove Unused CSS with Divi, we show an admin notice in some cases, to prompt the user to clear the Used CSS:
https://jmp.sh/9Oe3GtLW

But, the purge link is malformed, therefore does not work:
https://mega.wp-rocket.me/wp-admin/admin-post.php?_wpnonce=f9b9e8d279&action=rocket_clear_usedcss&_wp_http_referer=%2Fwp-admin%2Fplugins.php%3Fplugin_status%3Dall%26paged%3D1%26s

Note the nonce inserted in the middle.
Can be reproduced on Mega.

The customer sees a white screen after clicking the button.

To Reproduce
Steps to reproduce the behavior:

  1. Make sure Remove Unused CSS is enabled
  2. Go to Divi → Theme Builder
  3. Edit the Global Header
  4. After exiting the Divi builder, you'll see the admin notice - click the button

Expected behavior
The button should correctly purge the CSS and reload the page

Screenshots
https://jmp.sh/RGSRl0UH

Additional context
Tickets:
https://secure.helpscout.net/conversation/2628657922/497943?folderId=273766
https://secure.helpscout.net/conversation/2624405455/497101/#thread-7897077980

Acceptance Criteria (for WP Media team use only)
Clear instructions for developers, to be added before the grooming

@benorfaz benorfaz added module: remove unused css 3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting type: bug Indicates an unexpected problem or unintended behavior labels Jul 2, 2024
@piotrbak piotrbak added priority: low Issues that can wait severity: major Feature is not working as expected and no work around available labels Jul 17, 2024
@camilamadronero
Copy link

Rel case here: https://secure.helpscout.net/conversation/2660869953/504318/
Told customer to use the regular Clear Used CSS button in the time being

@webtrainingwheels webtrainingwheels changed the title Clear Used CSS button in Divi notice does not work Clear Used CSS button in Divi notice results in white screen Aug 1, 2024
@johan-las
Copy link

@joejoe04
Copy link

@johan-las
Copy link

@suzoutlet
Copy link

@webtrainingwheels
Copy link
Author

@webtrainingwheels
Copy link
Author

@johan-las
Copy link

@jekayode
Copy link

@joejoe04
Copy link

@juricazuanovic
Copy link
Contributor

@webtrainingwheels
Copy link
Author

@girlie
Copy link
Contributor

girlie commented Jan 4, 2025

@suzoutlet
Copy link

@webtrainingwheels
Copy link
Author

@Khadreal Khadreal self-assigned this Jan 14, 2025
@piotrbak piotrbak added this to the 3.18.1 milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting module: remove unused css priority: low Issues that can wait severity: major Feature is not working as expected and no work around available type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.