Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit multiple versions of an addon (while PR for a given version is still open) #30

Open
thomas-ernest opened this issue Aug 15, 2023 · 0 comments

Comments

@thomas-ernest
Copy link

Problem

I plugged Kodi addon submitter in my addon recetnly : https://github.com/thomas-ernest/plugin.video.arteplussept/blob/master/.github/workflows/release-addon.yml
I worked on few deliveries I wanted to be independnat with independant release versions, so that end-users can fallback in case of issue.

I first tag a commit with version 1.2.0. It submitted a pull-request to kodi plugin repo. This PR wasn't merged yet, while I delivered a new feature and tag another commit with version 1.3.1. It did NOT open a new pull-request. It updated the one with version 1.2.0 and put the content of 1.3.1 in it, without updating the title. My PR was inconsistent unfortunately.
Logs : Action execution with title "Bump version to 1.3.1" in https://github.com/thomas-ernest/plugin.video.arteplussept/actions?page=2

Candidate solutions

The goal of this issue is to support this usecase. Multiple optoins are possible :

  • Reject the new submittion and make CI fails.
  • Open a new pull-request with an independant version: Multiple PR open in parallel. (preferred)
  • Update the existing pull-request with the latest info an dallow to deliver only the last version of an addon.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant