Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No bars in OSMC with kodi 19 #91

Open
sylvaing26 opened this issue Jan 4, 2022 · 4 comments
Open

No bars in OSMC with kodi 19 #91

sylvaing26 opened this issue Jan 4, 2022 · 4 comments

Comments

@sylvaing26
Copy link

Hello,
I've an issue with shadertoy in OSMC qith Kodi v19.
When visualization is activated, for exemple with 2D Spectrum, I see only background.
I've not animations on bars when music is played

(Sorry for my bad english...)

Thanks

@sylvaing26
Copy link
Author

Hi,
I've solved the issue myself. Thanks to this post : https://discourse.osmc.tv/t/where-did-shadertoy-go/79424/12
I've compiled addon myself from source with changes.
The issue is due to the GL_RED and GL_LUMINANCE detection.

This is my procedure with OSMC :
sudo apt install git zip libgles2-mesa-dev build-essential git clone --branch Matrix https://github.com/xbmc/visualization.shadertoy.git git clone --branch Matrix https://github.com/xbmc/xbmc.git

Change to GLES :
nano /home/osmc/visualization.shadertoy CMakeLists.txt
Modify line 12 to
if(1 == 0)

Force GL_LUMINANCE
nano /home/osmc/visualization.shadertoy/src/main.cpp
Comment lines 24 and 26 like this :
//#ifndef GL_RED #define GL_RED GL_LUMINANCE //#endif

Rename plugin to Shadertoy 2 to disable conflict :
nano /home/osmc/visualization.shadertoy/visualization.shadertoy/addon.xml.in
Modify lines 3 and 5 like this :
id="visualization.shadertoy2" version="19.1.2" name="Shadertoy 2"

Compile addon :
cd visualization.shadertoy && mkdir build && cd build cmake -DADDONS_TO_BUILD=visualization.shadertoy -DADDON_SRC_PREFIX=../.. -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=../../xbmc/kodi-build/addons -DPACKAGE_ZIP=1 ../../xbmc/cmake/addons make

Link the addon folder to osmc :
ln -s ln -s /home/osmc/xbmc/kodi-build/addons/visualization.shadertoy /home/osmc/.kodi/addons/visualisation.shadertoy2

Restart raspberry and activate Shadertoy 2 module

@ildar170975
Copy link

ildar170975 commented Apr 1, 2022

Not sure if it is related but Shadertoy stopped working in LibreELEC 10 too.
Almost every preset does not show or shows just some static part of itself.
RPi 2.

@sylvaing26
Copy link
Author

sylvaing26 commented Apr 3, 2022

Yes it's related.
The issue was fixed on last osmc update : https://discourse.osmc.tv/t/visualizations-not-working-in-19-3/91899
It's due to GLES 3.
On RPI, it work only with GLES 2
I expect that Kodi's team also fix this issue...
You can open an issue on OpenElec too, they Can also fix it on her distribution...

@ghost
Copy link

ghost commented Jan 4, 2023

Amlogin, Android 6, Kodi 19.5, same issue, this patch working.

Hi, I've solved the issue myself. Thanks to this post : https://discourse.osmc.tv/t/where-did-shadertoy-go/79424/12 I've compiled addon myself from source with changes. The issue is due to the GL_RED and GL_LUMINANCE detection.

This is my procedure with OSMC : sudo apt install git zip libgles2-mesa-dev build-essential git clone --branch Matrix https://github.com/xbmc/visualization.shadertoy.git git clone --branch Matrix https://github.com/xbmc/xbmc.git

Change to GLES : nano /home/osmc/visualization.shadertoy CMakeLists.txt Modify line 12 to if(1 == 0)

Force GL_LUMINANCE nano /home/osmc/visualization.shadertoy/src/main.cpp Comment lines 24 and 26 like this : //#ifndef GL_RED #define GL_RED GL_LUMINANCE //#endif

Rename plugin to Shadertoy 2 to disable conflict : nano /home/osmc/visualization.shadertoy/visualization.shadertoy/addon.xml.in Modify lines 3 and 5 like this : id="visualization.shadertoy2" version="19.1.2" name="Shadertoy 2"

Compile addon : cd visualization.shadertoy && mkdir build && cd build cmake -DADDONS_TO_BUILD=visualization.shadertoy -DADDON_SRC_PREFIX=../.. -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=../../xbmc/kodi-build/addons -DPACKAGE_ZIP=1 ../../xbmc/cmake/addons make

Link the addon folder to osmc : ln -s ln -s /home/osmc/xbmc/kodi-build/addons/visualization.shadertoy /home/osmc/.kodi/addons/visualisation.shadertoy2

Restart raspberry and activate Shadertoy 2 module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants