From 3634f1e04638e044b0faa05b3160fbcf6ef72576 Mon Sep 17 00:00:00 2001
From: Lumi Pakkanen <lumi.pakkanen@gmail.com>
Date: Fri, 17 Jan 2025 16:25:34 +0200
Subject: [PATCH] Inform the user when equal temperament modal caps scale size

ref #402
---
 CHANGELOG.md                                          | 1 +
 src/components/modals/generation/EqualTemperament.vue | 5 ++++-
 src/stores/modal.ts                                   | 6 +++++-
 3 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 370414c1..41bb4faf 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,7 @@
   * Feature: Accept fractional values for CS variety margin [#821](https://github.com/xenharmonic-devs/scale-workshop/issues/821)
   * Feature: Add a button for calculating more MOS sizes in Rank 2 modal [#832](https://github.com/xenharmonic-devs/scale-workshop/issues/832)
   * Feature: Linear MIDI output mode (uses the numbers in the "#" column and assumes you tune the target device yourself) [#834](https://github.com/xenharmonic-devs/scale-workshop/issues/834)
+  * Feature: Display a warning when the user tries to create a scale larger than 1024 notes in *New scale -> Equal temperament* [#402](https://github.com/xenharmonic-devs/scale-workshop/issues/402)
   * Bug fix: Fix a crash in Rank 2 caused by temperaments with a negative number of periods per equave [#837](https://github.com/xenharmonic-devs/scale-workshop/issues/837)
 
 ## 3.1.0
diff --git a/src/components/modals/generation/EqualTemperament.vue b/src/components/modals/generation/EqualTemperament.vue
index e7b5aa5d..196846ac 100644
--- a/src/components/modals/generation/EqualTemperament.vue
+++ b/src/components/modals/generation/EqualTemperament.vue
@@ -3,7 +3,7 @@ import { OCTAVE } from '@/constants'
 import { ref, watch } from 'vue'
 import Modal from '@/components/ModalDialog.vue'
 import ScaleLineInput from '@/components/ScaleLineInput.vue'
-import { useModalStore } from '@/stores/modal'
+import { MAX_EQUAL_TEMPERAMENT_SIZE, useModalStore } from '@/stores/modal'
 import { setAndReportValidity } from '@/utils'
 import { useScaleStore } from '@/stores/scale'
 
@@ -111,6 +111,9 @@ function generate(expand = true) {
           />
         </div>
       </div>
+      <div class="warning" v-if="modal.divisions !== modal.safeScaleSize">
+        <p>Warning: Scale will be capped at {{ MAX_EQUAL_TEMPERAMENT_SIZE }} notes.</p>
+      </div>
     </template>
     <template #footer>
       <div class="btn-group">
diff --git a/src/stores/modal.ts b/src/stores/modal.ts
index 693ee0e7..fcd0aae4 100644
--- a/src/stores/modal.ts
+++ b/src/stores/modal.ts
@@ -26,6 +26,8 @@ function scaleGet(monzos: TimeMonzo[], index: number) {
   return monzos[mmod(index, monzos.length)].mul(equave.pow(numEquaves))
 }
 
+export const MAX_EQUAL_TEMPERAMENT_SIZE = 1024
+
 export const useModalStore = defineStore('modal', () => {
   // Generic
   const equaveString = ref('2/1')
@@ -57,7 +59,9 @@ export const useModalStore = defineStore('modal', () => {
   const singleStepOnly = computed(
     () => divisions.value !== Math.round(divisions.value) || divisions.value < 1
   )
-  const safeScaleSize = computed(() => Math.round(clamp(1, 1024, divisions.value)))
+  const safeScaleSize = computed(() =>
+    Math.round(clamp(1, MAX_EQUAL_TEMPERAMENT_SIZE, divisions.value))
+  )
   const jumps = computed(() => splitText(jumpsString.value).map((token) => parseInt(token, 10)))
   const degrees = computed(() => splitText(degreesString.value).map((token) => parseInt(token, 10)))