Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address accessibility report issues #128

Closed
cyberteenie opened this issue Oct 15, 2024 · 5 comments
Closed

Address accessibility report issues #128

cyberteenie opened this issue Oct 15, 2024 · 5 comments
Assignees
Labels
bug Something isn't working sla website

Comments

@cyberteenie
Copy link
Member

Please select the priority level by adding one of the following labels to this issue?

Priority-3 (Normal e.g. Functionality is not working for a subset of users)

Describe the bug and the expected behaviour.

https://www.notion.so/yallacooperative/Accessibility-Report-2024-080ed6364fe6485a8d7adcb68286b803?pvs=4

Steps To Reproduce

No response

Screenshots or a link to a Loom Recording

No response

What browsers are you seeing the problem on?

No response

Anything else?

No response

@AbdelhalimOJ
Copy link
Collaborator

last stop: About Us page

@AbdelhalimOJ
Copy link
Collaborator

Hi @cyberteenie, I've addressed most of the points in this report
Here are the remaining points we can create separate issues for:

  • Touch Target Spacing
  • Keyboard Navigation
  • Customisation Options for Better Accessibility
  • Other suggestions

@AbdelhalimOJ
Copy link
Collaborator

AbdelhalimOJ commented Jan 27, 2025

@cyberteenie

For "Touch Target Spacing," it’s recommended to have at least 8px of space around each interactive element. I’ve checked all the pages, and this seems to be done. Do you think there’s anywhere it isn’t?

I finished working on "Keyboard Navigation" and noticed that all Slick sliders need to be replaced with SwiperJS sliders because Slick isn't accessible. For example, the navigation dots can't be focused. so all is good about keyboard navigation except for the slider on the home page which will be changed to SwiperJS.

@cyberteenie
Copy link
Member Author

Ok, thanks for the update @AbdelhalimOJ - feel free to update the sliders.
I can have a spot check around the website regarding the touch target spacing.

@AbdelhalimOJ
Copy link
Collaborator

all items are ticked except for the extra suggestion about redesigning cards. @cyberteenie

check the new accessibility toolbar here: https://www.loom.com/share/fdfc231c8e494b7da65c5e23f81d5fc7?sid=be35b0bb-dae2-461e-a054-e6723dd24e2e (video might still be loading)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sla website
Projects
None yet
Development

No branches or pull requests

3 participants