Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opinions - bin/www #146

Open
tyeung2017 opened this issue May 6, 2019 · 0 comments
Open

Opinions - bin/www #146

tyeung2017 opened this issue May 6, 2019 · 0 comments
Labels
Milestone

Comments

@tyeung2017
Copy link

I know it is generated from express-generator and lots of ppl just use it without questions

Below is only my personal preference:

  1. prefer declaring functions at the top rather than bottom of the page as the reader would need to look all over your file to find the functions

  2. some of the config there is overkilled, like normalisePorts; since you are controlling the env variable for port, it is kind of redundant; less is more

https://stackoverflow.com/questions/47276081/expressjs-normalizeport-function-is-really-necessary

@dupreesi dupreesi added this to the SPRINT 4 milestone Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants