Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we don't lose images again like we did with postimg.org -> postimg.cc #372

Open
dniku opened this issue Apr 15, 2020 · 3 comments

Comments

@dniku
Copy link
Collaborator

dniku commented Apr 15, 2020

via @yhn112:

Let's choose one of:

  1. embed images to notebooks
  2. host images in our repo
  3. host images on some image hosting
  4. find all the images on the existing sources.

Currently we use all 4 ways in different places.

@yhn112
Copy link
Collaborator

yhn112 commented Apr 19, 2020

Option 1.5: embed images in base64 via html tags. Works with github and colab, but looks a bit ugly when editing markdown cells with it.

@justheuristic
Copy link
Contributor

IMHO
1., 1.5, - i would recommend switching to this option IF github can render such images. And it would be nice if someone created an instruction for that.
2. this would either require absolute URLs that must be changed on every new branch OR relative urls that are gone in colab
3. for example, imgur seems too large to fail in the conceivable future, but it is still less reliable than (1, 1.5)
4. least reliable option that we used previously to save time. The only justifiable reason to do that would be if we are legally forbidden from copying image to our repo

@dniku
Copy link
Collaborator Author

dniku commented Apr 22, 2020

We can also host images on Github, like PyTorch docs do: pytorch/pytorch#32158 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants