Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sensitive headers logged in info log #16488

Closed
sanjakovac opened this issue Jul 6, 2018 · 1 comment
Closed

Sensitive headers logged in info log #16488

sanjakovac opened this issue Jul 6, 2018 · 1 comment
Labels
ext:authclient

Comments

@sanjakovac
Copy link

sanjakovac commented Jul 6, 2018 •
edited
Loading

What steps will reproduce the problem?

  • Turn on info log in your application
  • Use function Yii/authclient/BaseOAuth.SendRequest to do Http POST request

What is the expected result?

Yii/httpclient/StreamTransport.send should log only basic information about request.
Token should not be logged in info log, since it may contain sensitive information. Values of headers carrying sensitive information, should be obfuscated.

What do you get instead?

Yii/httpclient/StreamTransport.send will log all the headers including username/password if it was sent with request.

Additional info

Q A
Yii httpclient version 2.0.6.0
PHP version 7.0
Operating system MacOS
@yii-bot yii-bot mentioned this issue Jul 6, 2018
Open
@yii-bot
Copy link

yii-bot commented Jul 6, 2018

Issue moved to yiisoft/yii2-authclient#235

@yii-bot yii-bot closed this as completed Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ext:authclient
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samdark @yii-bot @sanjakovac