Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location of some 2kki badges displays as unknown while playing a different game #496

Open
krossower1 opened this issue Jul 18, 2024 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@krossower1
Copy link
Contributor

I already attempted to fix this and was unable, but since the original issue got closed, I will create it again. Only happens with some of the badges in 2kki
image

@Desdaemon
Copy link
Contributor

I already left a TODO here if someone wants to fix this:

forest-orb/badges.js

Lines 526 to 528 in aab2953

// TODO: To remove the last condition and allow searching 2kki badges by location from all games,
// a 2kki-specific cache must be set up and populated from cache and/or queried
if (!title && item.game === '2kki' && gameId === '2kki') {

@notdistorted notdistorted added bug Something isn't working help wanted Extra attention is needed labels Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants