Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select frame for thumbnail extraction #1051

Open
2 tasks done
Technical-Director opened this issue Dec 12, 2024 · 4 comments · May be fixed by #1052
Open
2 tasks done

Select frame for thumbnail extraction #1051

Technical-Director opened this issue Dec 12, 2024 · 4 comments · May be fixed by #1052
Labels
community Issues and PRs coming from the community members type: enhancement Improvement of existing functionality or minor addition

Comments

@Technical-Director
Copy link

Is there an existing issue for this?

  • I have searched the existing issues.

Please describe the feature you have in mind and explain what the current shortcomings are?

Right now when using the extract_thumbnail plugin AYON is picking the middle frame by default.
It would be nice to have an option in the settings to select a specific frame which is used for that.

How would you imagine the implementation of the feature?

Image

  • Add a optional field to type in the frame which should be selected for the thumbnail
  • When no frame is selected it should use the middle frame by default

Are there any labels you wish to add?

  • I have added the relevant labels to the enhancement request.

Describe alternatives you've considered:

No response

Additional context:

I have already implemented that locally but a question about the field in the AYON publisher: How are you handling frame ranges in AYON? For example in my DCC i am starting with frame 1001. But the extraction uses the video file so there the frame count starts by 0.

In my current implementation for that I prefere to select the frame which is displayed in my dcc so frame 1005 for example.
@Technical-Director Technical-Director added the type: enhancement Improvement of existing functionality or minor addition label Dec 12, 2024
@Technical-Director Technical-Director linked a pull request Dec 12, 2024 that will close this issue
Open
@jakubjezek001
Copy link
Member

Hey @Dreamink-Official thank you for the request. I was wondering if it is necessary to know exact number of the frame for thumbnail or whether it could be just explicit frame agnostic approach which is already implemented now.

Here in settings you are able to set float number referring to what part of total 100% range the frame should be taken. Yes it is approximating a little.

ayon+settings://core/publish/ExtractThumbnail/duration_split

@jakubjezek001 jakubjezek001 added the community Issues and PRs coming from the community members label Jan 22, 2025
@Technical-Director
Copy link
Author

For me, (as a developer), the explicit frame-agnostic approach would be fine. But my artists specifically asked for a way to select the frame shown as the thumbnail, so I added this feature.

They told me:

  • Sometimes the selected frame just doesn’t represent the shot well. Being able to pick a specific frame lets them show the most important moment.
  • It gives them more control over how their work is presented, which matters a lot to them.
  • It’s just a bit more flexible. Most of the time, the frame-agnostic approach works fine, but when you really need to highlight something specific, this makes it possible.

@BigRoy
Copy link
Collaborator

BigRoy commented Jan 23, 2025

But my artists specifically asked for a way to select the frame shown as the thumbnail, so I added this feature.

Any chance you can contribute back (or can share) your changes?

@Technical-Director
Copy link
Author

Of course! I did created a PR back in time for that (#1052)

@BigRoy BigRoy linked a pull request Jan 23, 2025 that will close this issue
Select frame for thumbnail extraction #1052
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community Issues and PRs coming from the community members type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Select frame for thumbnail extraction Technical-Director/ayon-core
3 participants
@BigRoy @Technical-Director @jakubjezek001