Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delivery: Use current roots during delivery #978

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Make sure that root is not re-used from published representation during delivery.

Additional info

Because we do copy "context" it also copied "root" there, if root is filled in template data, anatomy does not auto-fill it which causes issues during delivery.

Testing notes:

  1. Publish some representation (can skip if you have any).
  2. Create new root in the project.
  3. Use the new root in delivery template.
  4. Run delivery action in loader.
  5. It should work fine and should not raise error because of missing root key.

@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Oct 30, 2024
@iLLiCiTiT iLLiCiTiT self-assigned this Oct 30, 2024
@ynbot ynbot added the size/XS label Oct 30, 2024
@iLLiCiTiT iLLiCiTiT requested review from 64qam and MilaKudr October 30, 2024 13:13
iLLiCiTiT and others added 2 commits October 30, 2024 14:30
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question @iLLiCiTiT - before this PR ... there may be usage of delivery templates of {root} in delivery templates. That would break now because one would require now to specify the children? Or was root already a dict in context too?

@iLLiCiTiT
Copy link
Member Author

there may be usage of delivery templates of {root} in delivery templates.

I don't think it was, you would still have to use {root[...]} in template.

Or was root already a dict in context too?

Yes, but only with one root, and one platform.

@iLLiCiTiT iLLiCiTiT merged commit 070d3a5 into develop Oct 30, 2024
5 checks passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/delivery-use-current-anatomy-roots branch October 30, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants