Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AY-6973_Failing publishing with source resolution #24

Open
ynbot opened this issue Oct 22, 2024 · 4 comments
Open

AY-6973_Failing publishing with source resolution #24

ynbot opened this issue Oct 22, 2024 · 4 comments
Assignees
Labels
sponsored This is directly sponsored by a client or community member

Comments

@ynbot
Copy link
Contributor

ynbot commented Oct 22, 2024

Please describe the issue you have encountered?

Clients have reported that the resolution toggle is not working correctly. It either crashes the publishing process or, when disabled, sets the published resolution to the source resolution, which is the opposite of the intended behavior.

How to replicate the issue?

No response

Additional context:

link to discussion on Discord
(might be a private channel)

This issue was automatically created from Clickup ticket AY-6973

@ynbot ynbot added sponsored This is directly sponsored by a client or community member type: bug Something isn't working labels Oct 22, 2024
@dee-ynput dee-ynput removed the type: bug Something isn't working label Nov 1, 2024
@m-u-r-p-h-y
Copy link
Member

@jakubjezek001 mentioned this #7 to fix the issue. Does it solve the issue?

@robin-ynput
Copy link
Contributor

@m-u-r-p-h-y , @jakubjezek001

Looked into it today, I cannot reproduce the issue with 1.0.0 indeed.

Unless there is a specific set of settings/media that make it fails, it looks OK to me. I've tested simple clips, multiple clips, vertical aligned from both EXR, TIF and QT sources and each time source resolution was properly detected and applied when enabled.

Should we go ahead and close the ticket or asked for client feedback ?

@robin-ynput
Copy link
Contributor

robin-ynput commented Dec 16, 2024

Discussed with @jakubjezek001 today, we should turn this ticket into a feature request so the user can control the shot resolution (width, height, pixel aspect ratio) as a plugin attributes.

We can inspire ouselves from ayon-traypublisher\client\ayon_traypublisher\plugins\publish\collect_explicit_colorspace.py

@robin-ynput
Copy link
Contributor

Marking this one as done, because it looks like the feature request will actually be handled via
#46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sponsored This is directly sponsored by a client or community member
Projects
None yet
Development

No branches or pull requests

4 participants