Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collect component builder don't cook node #197

Open
1 task done
MustafaJafar opened this issue Dec 16, 2024 · 3 comments
Open
1 task done

collect component builder don't cook node #197

MustafaJafar opened this issue Dec 16, 2024 · 3 comments
Assignees
Labels
type: enhancement Improvement of existing functionality or minor addition

Comments

@MustafaJafar
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues and added correct labels.

Please describe the feature you have in mind and explain what the current shortcomings are?

as mentioned in #193 (comment) and #193 (comment)

The issue was originally with the node.cook() removed is that if there were errors (e.g. make it break now in your local scene)... then fix your scene so it should render correctly, and then just publish but don't recook the node manually that the original errors would still be listed from node.errors()

The comment in code mentions that to "force a cook" purely to clear out EXISTING errors prior to the render.

The issue we face initially was that if the ROP or graph had previously errored, that just doing the execute button would fail because it wouldn't resolve that the problem has been 'fixed' since. (It may have been that the Houdini session was set to "Update on mouse up" or whatever - but if we can't reproduce it. Then let's clean it up and remove the cook.

Suggested implementation?

.

Describe alternatives you've considered:

.

@MustafaJafar MustafaJafar added the type: enhancement Improvement of existing functionality or minor addition label Dec 16, 2024
@MustafaJafar MustafaJafar self-assigned this Dec 16, 2024
@MustafaJafar MustafaJafar changed the title collect component builder remove redundant logic collect component builder don't cook node Dec 16, 2024
@MustafaJafar
Copy link
Contributor Author

MustafaJafar commented Dec 16, 2024

Creating this issue to discuss this topic outside of #193.
Tagging @BigRoy and @moonyuet for visibility.

So, discovering errors after removing node.cook(force=True) won't work in these cases:

  1. Open the file in the obj network, and trigger validate in publisher.
  2. Setting File to Manual.

In both cases the node fails to export files and it fails on integrate step.

Image

@BigRoy
Copy link
Contributor

BigRoy commented Dec 17, 2024

So, discovering errors after removing node.cook(force=True) won't work in these cases:

1. Open the file in the obj network, and trigger validate in publisher.

2. Setting File to `Manual`.

In both cases the node fails to export files and it fails on integrate step.

Correct - things not working in Manual mode is actually a known issue, see: #51 and I'd say unrelated to what's brought up with this issue.

I think step 1) in Auto Update mode, might be what this issue is about.

@moonyuet
Copy link
Member

moonyuet commented Dec 17, 2024

This issue seems to be the files not being saved as expected, and thus errors out the integrator?
I got some idea to possibly solve the issue from this discussion: https://www.sidefx.com/forum/topic/68535/

node = hou.node(node_path)
node.cook(force=True)
node.executeGraph(False, True, False, False)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

No branches or pull requests

3 participants