Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjustment of the orientation for fbx animation import in 5.5 #193

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Adjustment of the orientation for fbx animation import in 5.5 #193

merged 2 commits into from
Jan 23, 2025

Conversation

moonyuet
Copy link
Member

@moonyuet moonyuet commented Jan 22, 2025 •
edited
Loading

Changelog Description

Fix #191
This PR is to make sure the correct x rotation of the animation sequence when performing connect action with layout and animation product in fbx.

Additional review information

n/a

Testing notes:

  1. Launch Unreal in the launcher which installed with the built addon of this branch
  2. Load Layout and fbx animation
  3. Go to manage
  4. Select layout and fbx animation container and perform connect action.

@moonyuet moonyuet added the type: bug Something isn't working label Jan 22, 2025
@moonyuet moonyuet requested a review from LiborBatek January 22, 2025 12:01
@moonyuet moonyuet self-assigned this Jan 22, 2025
@LiborBatek
Copy link
Member

LiborBatek commented Jan 22, 2025 •
edited
Loading

...while testing I was about to bring some animation freshly too but for some reason I do miss Load animation (FBX) just Alembic present...

image

Traceback (most recent call last):
  File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\core_1.0.14\ayon_core\lib\python_module_tools.py", line 79, in modules_from_path
    module = import_filepath(full_path, mod_name)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\core_1.0.14\ayon_core\lib\python_module_tools.py", line 31, in import_filepath
    module_loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\unreal_0.2.7+dev\ayon_unreal\plugins\load\load_animation.py", line 7, in <module>
    from ayon_core.pipeline import (AYON_CONTAINER_ID, get_current_project_name,
ImportError: cannot import name 'UNREAL_VERSION' from 'ayon_core.pipeline' (C:\Users\lbate\AppData\Local\Ynput\AYON\addons\core_1.0.14\ayon_core\pipeline\__init__.py)
********** ]

@LiborBatek
Copy link
Member

I have tried to switch to older ayon-core version 1.0.13 but getting the same error

LiborBatek
LiborBatek approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have been tested with older assets and also freshly published ones and the connect Anim (FBX) results into correct transforms in both occasions.

LGTM!

image

@moonyuet moonyuet merged commit 5c76bfb into develop Jan 23, 2025
1 check passed
@moonyuet moonyuet deleted the bugfix/animation_sequence_incorrect_rotation_x_in_5.5 branch January 23, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiborBatek LiborBatek LiborBatek approved these changes

Assignees

@moonyuet moonyuet

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Connect Animation" action results into wrong transforms on skeletonAnimation actor (rot x -90 missing)
2 participants
@moonyuet @LiborBatek