Change desktop publishing options to upload artifacts #423
Conversation
WalkthroughThe pull request modifies the GitHub Actions workflow for the Changes
Assessment against linked issues
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🔇 Additional comments (4).github/workflows/desktop-publish.yml (1)
The change from Let's verify this is a common pattern with electron-builder: ✅ Verification successfulLet me gather more information about electron-builder's GH_TOKEN usage pattern. Let me try a different approach to find electron-builder configuration. Let me search for electron-builder configuration files to verify the GH_TOKEN usage pattern. Based on the findings, I can now generate the final response: Verified! The GH_TOKEN environment variable is the correct configuration for electron-builder The change is correct as evidenced by:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Search for similar GH_TOKEN usage in electron-builder workflows
rg -l "GH_TOKEN.*secrets.GITHUB_TOKEN" .github/
Length of output: 87 Script: #!/bin/bash
# Search for electron-builder configuration and documentation references
fd -e json -e js "electron-builder" --exec cat {}
Length of output: 51 Script: #!/bin/bash
# Look for package.json files that might contain electron-builder config
fd "package.json" --exec cat {} | grep -A 10 -B 10 "electron-builder"
# Also search for any yml/yaml files that might contain electron-builder config
fd -e yml -e yaml . --exec cat {}
Length of output: 72743 Script: #!/bin/bash
# Search for electron-builder config in package.json and other config files
rg -A 5 -B 5 '"build":\s*{' package.json
rg -A 5 -B 5 "electron-builder" .
Length of output: 7578 desktop/package.json (3)
The addition of
The publish configuration looks correct with GitHub provider and release type. Let's verify this matches electron-builder's recommended setup. Check for any missing recommended publish configuration: ✅ Verification successfulPublish configuration is correctly set up The electron-builder configuration in package.json is complete and follows the recommended setup:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Search for similar electron-builder publish configurations
rg -A 5 '"publish":\s*{' --type json
# Check package.json for any other electron-builder specific configurations
rg '"electron-builder"' package.json
Length of output: 169 Script: #!/bin/bash
# Search for similar electron-builder publish configurations with fixed regex
rg -A 5 '"publish": \{' --type json
# Search for electron-builder config in package.json
cat desktop/package.json | jq '.["build"]'
Length of output: 975
While the casing change from "codepair" to "CodePair" improves branding consistency, we should verify this won't cause issues with existing installations. Let's check for any hardcoded references to the old name: ✅ Verification successfulProduct name change from "codepair" to "CodePair" appears safe The casing change in
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Search for potential hardcoded references to the old product name
rg -i "productName.*codepair" --type yaml --type typescript --type javascript
rg -i "com\.yorkie-team\.codepair" --type yaml --type typescript --type javascript
Length of output: 234 Script: #!/bin/bash
# Search for potential hardcoded references to the old product name using ripgrep
# without file type restrictions to catch all occurrences
rg -i "codepair"
# Also specifically check package.json files
fd "package.json" --exec grep -i "codepair" {}
Length of output: 32249 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
devleejb
deleted the
422-github-actions-not-uploading-artifacts-for-electron-application-release
branch
What this PR does / why we need it:
As the
electron-builderonly detects releases which the release type isdraft, the github actions don't upload artifacts. So this PR changes the detection draft type toreleaseand deletes redundant uploading actions.Which issue(s) this PR fixes:
Fixes #422
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist:
Summary by CodeRabbit
New Features
releaseTypeproperty to enhance build configurations.Bug Fixes
Chores
GITHUB_TOKENtoGH_TOKENin the build process.