Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change mount.rs find_parent_mount from pub to private #2814

Open
lengrongfu opened this issue Jun 12, 2024 · 4 comments
Open

change mount.rs find_parent_mount from pub to private #2814

lengrongfu opened this issue Jun 12, 2024 · 4 comments

Comments

@lengrongfu
Copy link
Collaborator

The current find_parent_mount method is only in impl Mount use, we can change to private fn from pub fn.
https://github.com/containers/youki/blob/4d4ce7c3710d1ed8f155adf23fb62dc672197043/crates/libcontainer/src/rootfs/mount.rs#L614

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Jun 12, 2024

Note that this change would likely be a breaking change, so PR should be labeled accordingly, along with changelog info.

@utam0k
Copy link
Member

utam0k commented Jun 13, 2024

@Mossaka Do you use this function in runwasi?

@Mossaka
Copy link
Contributor

Mossaka commented Jun 13, 2024

No, it's not used in runwasi. However, I would be more careful in making breaking changes if we don't have a strong motivation.

@lengrongfu
Copy link
Collaborator Author

Thanks every body suggestion, we can hold this issue, keep watch, and then decide how to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants