We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mount.rs
The current find_parent_mount method is only in impl Mount use, we can change to private fn from pub fn. https://github.com/containers/youki/blob/4d4ce7c3710d1ed8f155adf23fb62dc672197043/crates/libcontainer/src/rootfs/mount.rs#L614
find_parent_mount
impl Mount
private fn
pub fn
The text was updated successfully, but these errors were encountered:
Note that this change would likely be a breaking change, so PR should be labeled accordingly, along with changelog info.
Sorry, something went wrong.
@Mossaka Do you use this function in runwasi?
No, it's not used in runwasi. However, I would be more careful in making breaking changes if we don't have a strong motivation.
Thanks every body suggestion, we can hold this issue, keep watch, and then decide how to resolve.
No branches or pull requests
The current
find_parent_mount
method is only inimpl Mount
use, we can change toprivate fn
frompub fn
.https://github.com/containers/youki/blob/4d4ce7c3710d1ed8f155adf23fb62dc672197043/crates/libcontainer/src/rootfs/mount.rs#L614
The text was updated successfully, but these errors were encountered: