Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

screenshot times are off #208

Open
yshavit opened this issue Apr 9, 2021 · 0 comments
Open

screenshot times are off #208

yshavit opened this issue Apr 9, 2021 · 0 comments

Comments

@yshavit
Copy link
Owner

yshavit commented Apr 9, 2021

When we auto-generate the screenshots in the GH action, we set the system time zone such that it's 6 or 7pm (8a8daa5), but we don't adjust the mocked clock's time zone to compensate, nor do we adjust the mock event's times. We should. Specifically:

  • We should use the system time zone for this test, not the usual mocked one
  • To calculate the event times, we should just use Calendar's date(bySettingHour: ...) to the hours and minutes of the events.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant