Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Dockerfile & Docker documentation #3336

Closed
robertcheramy opened this issue Dec 5, 2024 · 1 comment
Closed

Improve Dockerfile & Docker documentation #3336

robertcheramy opened this issue Dec 5, 2024 · 1 comment
Assignees
@robertcheramy
Labels
bug enhancement
Milestone
0.33

Comments

@robertcheramy
Copy link
Collaborator

robertcheramy commented Dec 5, 2024 •
edited
Loading

As stated in Issue #3331, there are some Problems with the docker container:

  • Fixed: bd8d579 introduced the creation of /home/oxidized/.config/oxidized/, owned by root
  • f02d689 stated in README.md the option --user oxidized which does not work without extra setup
  • Fixed: there is an ubuntu user in the image, which should not be there

I think we should move detailed instructions on running oxidized within docker in an extra document as README.md, so that we can introduce more details and make the user experience smoother.
@robertcheramy robertcheramy added this to the 0.32 milestone Dec 5, 2024
@robertcheramy robertcheramy self-assigned this Dec 5, 2024
@robertcheramy robertcheramy mentioned this issue Dec 5, 2024
Open
@robertcheramy robertcheramy modified the milestones: 0.32, 0.33 Feb 17, 2025
robertcheramy added a commit that referenced this issue Feb 21, 2025
@robertcheramy
dockerfile: remove ubuntu user
b0d6e9c 
Partly adresses issue #3336 and #3331.
Thanks @rmcmilli for the hint.
robertcheramy added a commit that referenced this issue Feb 24, 2025
@robertcheramy
docker-image: Correct rights under /home/oxidized
65baab9 
Partly adresses issue #3336
robertcheramy added a commit to robertcheramy/oxidized that referenced this issue Feb 26, 2025
@robertcheramy
Update Dockerfile & Documentation
15bc39c 
- Reverts the pre-build stage with GEM_HOME as it broke things. I've
found a solution which is quite as much compact, but it takes a longer
time to build. Closes Issue ytti#3331
- Improve the docker documentation. Closses Issue ytti#3336
- Remove examples/podman-compose as it is described in the docker
documentation.
- fix rake build_container to comply with the tags in the new GitHub CI.
@robertcheramy robertcheramy mentioned this issue Feb 26, 2025
Merged
4 tasks
robertcheramy added a commit that referenced this issue Feb 26, 2025
@robertcheramy
Update docker build & documentation (#3429)
4ea37b9 
* Update Dockerfile & Documentation

- Reverts the pre-build stage with GEM_HOME as it broke things. I've
found a solution which is quite as much compact, but it takes a longer
time to build. Closes Issue #3331
- Improve the docker documentation. Closses Issue #3336
- Remove examples/podman-compose as it is described in the docker
documentation.
- fix rake build_container to comply with the tags in the new GitHub CI.
@robertcheramy
Copy link
Collaborator Author

Fixed by #3429

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertcheramy robertcheramy

Labels
bug enhancement
Projects
None yet
Milestone
0.33
Development

No branches or pull requests
1 participant
@robertcheramy