Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rake task name collision (almost) #80

Open
vfonic opened this issue Sep 3, 2021 · 0 comments
Open

Rake task name collision (almost) #80

vfonic opened this issue Sep 3, 2021 · 0 comments

Comments

@vfonic
Copy link
Contributor

vfonic commented Sep 3, 2021

I noticed that artemis adds a new rake task: graphql:schema:update. This could be potentially dangerous because graphql gem adds graphql:* rake tasks:

rails graphql:pro:validate[gem_version] # Get the checksum of a graphql-pro version and compare it to published versions on GitHub and graphql-ruby.org
rails graphql:schema:dump               # Dump the schema to JSON and IDL
rails graphql:schema:idl                # Dump the schema to IDL in ./schema.graphql
rails graphql:schema:json               # Dump the schema to JSON in ./schema.json

For a gem called graphql, it makes sense to use graphql namespace. For artemis, I'd suggest you add an artemis namespace: artemis:*.

In this concrete example, perhaps the rake task would be: artemis:update_graphql_schema (or any other that you see fit).

https://github.com/yuki24/artemis#rake-tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant