Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sweep: Unintended 404 for "Tambahkan Aktivitas" button to /new from home and about page #51

Open
mhaidarhanif opened this issue Jul 30, 2023 · 0 comments · May be fixed by #52
Open

Sweep: Unintended 404 for "Tambahkan Aktivitas" button to /new from home and about page #51

mhaidarhanif opened this issue Jul 30, 2023 · 0 comments · May be fixed by #52
Labels
bug Something isn't working

Comments

@mhaidarhanif
Copy link

Description

The link/button for "Tambahkan Aktivitas" is shown for every pages.

But home and about doesn't have /new route.

Therefore there are 404 on these:

  • beta.senar.ai/new
  • beta.senar.ai/about/new

Expected Behaviour

The link/button should not be shown on home and about page.

Additional Information

Can condition the layout/header/nav with some props to show/hide the button.
@mhaidarhanif mhaidarhanif added the bug Something isn't working label Jul 30, 2023
@zainfathoni zainfathoni changed the title Unintended 404 for "Tambahkan Aktivitas" button to /new from home and about page Sweep: Unintended 404 for "Tambahkan Aktivitas" button to /new from home and about page Aug 7, 2023
@zainfathoni zainfathoni linked a pull request Aug 25, 2023 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: render "Tambahkan Aktivitas" button conditionally zainfathoni/senar.ai
1 participant
@mhaidarhanif