Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sanity check whether the input data contains duplicated entities #33

Open
jbao opened this issue Jun 28, 2016 · 5 comments
Open

sanity check whether the input data contains duplicated entities #33

jbao opened this issue Jun 28, 2016 · 5 comments

Comments

@jbao
Copy link

jbao commented Jun 28, 2016

The ExperimentData class can handle 2 kinds of input data as the metrics argument:

  • aggregated metrics: this should always be aggregated on the entity level
  • time-resolved metrics: this requires an additional column time_since_treatment in the input, and should always be aggregated per unique entity and time point
@piyush0609
Copy link

I am willing to work on this. Maybe you can explain a bit more.

@jbao
Copy link
Author

jbao commented Aug 22, 2016

hey @piyush0609 , glad that you volunteered, just added some description, feel free to reach out if it's still unclear;-)

@piyush0609
Copy link

So what do we want to do here @jbao, from your comment earlier what I understood is that we have to make some changes in time_resolved metrics.

@jbao
Copy link
Author

jbao commented Aug 22, 2016

basically we need to distinguish the two metric types:

  • if aggregated, we need to add a checkpoint to ensure all entities are unique
  • if time-resolved, we need to ensure the data is unique based on the combination of entity and time

@piyush0609
Copy link

I am not sure that I can do it, but I will definitely try and I will be needing your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants