Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change proprietary headers format in the hint for Rule 183 #651

Closed
vadeg opened this issue Apr 10, 2021 · 4 comments · Fixed by #652 or #673
Closed

Change proprietary headers format in the hint for Rule 183 #651

vadeg opened this issue Apr 10, 2021 · 4 comments · Fixed by #652 or #673
Assignees

Comments

@vadeg
Copy link
Contributor

vadeg commented Apr 10, 2021

Proprietary headers in Rule 183 doesn't match Rule 132.

@tfrauenstein
Copy link
Member

I think we should Rule 132 to the proprietary header section and include 'X-' prefixing -- Common / standard headers are anyway not in our naming responsibility. What additional concrete mismatches you see?

@vadeg
Copy link
Contributor Author

vadeg commented Apr 13, 2021

Common / standard headers are anyway not in our naming responsibility

Then it could happen that we will see a lot of location instead of Location and accept-encoding instead of Accept-Encoding headers in APIs with arguments like "headers are case-insensitive anyways".

Should we mention in the Rule 133 than you should preserve naming convension for standard headers?

@tfrauenstein
Copy link
Member

yes -- see my proposal #653

@tkrop
Copy link
Member

tkrop commented Jun 1, 2021

Layout changes are transferred to #660.

@tkrop tkrop closed this as completed Jun 1, 2021
@tkrop tkrop reopened this Jun 1, 2021
tkrop pushed a commit that referenced this issue Jun 29, 2021
tfrauenstein added a commit that referenced this issue Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants