Skip to content
This repository has been archived by the owner on Aug 27, 2024. It is now read-only.

Consider a 👍 in a review approval in addition to a comment #536

Closed
ancelotpinto opened this issue Aug 6, 2018 · 2 comments
Closed

Consider a 👍 in a review approval in addition to a comment #536

ancelotpinto opened this issue Aug 6, 2018 · 2 comments

Comments

@ancelotpinto
Copy link

Currently, only 👍 in a comment is consider. Adding support for this will enable the use of the github feature where we can review changes since the last approval or comment.

This is useful in a situation where we give an approval and the user updates the PR after.

@lotharschulz
Copy link
Contributor

https://zappr.readthedocs.io/en/latest/setup/#zappr-features-and-their-configuration-options lists several configuration options including pattern : ^(:+1:|👍)$

With that you can configure other patterns to express that you like the change.

Would that help?

Apart from that, zappr approvals become void once a new commit is pushed to the PR in question.

@ancelotpinto
Copy link
Author

Thanks, this information is useful.

I was referring specifically to the native github review process where we can comment with an approval, but I realised that this is already being tracked in this issue:

Support native approvals
#442

Please close this as a duplicate ticket to #442

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants