From 8a8ebbe59f10f4d42712d51e4313146f27e7e73c Mon Sep 17 00:00:00 2001
From: Joseph Lombrozo <joe.lombrozo@zapier.com>
Date: Mon, 24 Feb 2025 11:34:27 -0500
Subject: [PATCH] log pipeline errors when they occur (#341)

---
 pkg/vcs/gitlab_client/pipeline.go | 57 +++++++++++++++----------------
 1 file changed, 27 insertions(+), 30 deletions(-)

diff --git a/pkg/vcs/gitlab_client/pipeline.go b/pkg/vcs/gitlab_client/pipeline.go
index a1bbcf07..4deaa80f 100644
--- a/pkg/vcs/gitlab_client/pipeline.go
+++ b/pkg/vcs/gitlab_client/pipeline.go
@@ -7,51 +7,48 @@ import (
 	"github.com/zapier/kubechecks/pkg"
 )
 
-func (c *Client) GetPipelinesForCommit(projectName string, commitSHA string) ([]*gitlab.PipelineInfo, error) {
+func (c *Client) GetLastPipelinesForCommit(projectName string, commitSHA string) *gitlab.PipelineInfo {
 	pipelines, _, err := c.c.Pipelines.ListProjectPipelines(projectName, &gitlab.ListProjectPipelinesOptions{
 		SHA: pkg.Pointer(commitSHA),
 	})
 	if err != nil {
-		log.Error().Err(err).Msg("gitlab client: could not get pipelines for commit")
-		return pipelines, err
+		log.Error().Err(err).Msg("gitlab client: could not get last pipeline for commit")
+		return nil
 	}
 
-	return pipelines, nil
+	log.Debug().Int("pipline_count", len(pipelines)).Msg("gitlab client: retrieve pipelines for commit")
 
-}
-
-func (c *Client) GetLastPipelinesForCommit(projectName string, commitSHA string) *gitlab.PipelineInfo {
-	pipelines, err := c.GetPipelinesForCommit(projectName, commitSHA)
-	if err != nil {
-		return nil
+	for _, p := range pipelines {
+		log.Debug().
+			Int("pipeline_id", p.ID).
+			Str("source", p.Source).
+			Msg("gitlab client: pipeline details")
 	}
 
-	if len(pipelines) > 0 {
-		// check for merge_requests_event
-		for _, p := range pipelines {
-			if p.Source == "merge_request_event" {
-				return p
-			}
+	// check for merge_requests_event
+	for _, p := range pipelines {
+		if p.Source == "merge_request_event" {
+			return p
 		}
+	}
 
-		// check for external_pull_request_events next
-		for _, p := range pipelines {
-			if p.Source == "pipeline" {
-				return p
-			}
+	// check for external_pull_request_events next
+	for _, p := range pipelines {
+		if p.Source == "pipeline" {
+			return p
 		}
+	}
 
-		// check for external_pull_request_events next
-		for _, p := range pipelines {
-			if p.Source == "external_pull_request_event" {
-				return p
-			}
+	// check for external_pull_request_events next
+	for _, p := range pipelines {
+		if p.Source == "external_pull_request_event" {
+			return p
 		}
+	}
 
-		for _, p := range pipelines {
-			if p.Source == "external" {
-				return p
-			}
+	for _, p := range pipelines {
+		if p.Source == "external" {
+			return p
 		}
 	}