Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for group creation across all mode options #2630

Open
d-v-b opened this issue Jan 3, 2025 · 3 comments · May be fixed by #2690 or #2840
Open

Test for group creation across all mode options #2630

d-v-b opened this issue Jan 3, 2025 · 3 comments · May be fixed by #2690 or #2840
Labels
good-first-issue Good place to get started as a new contributor. tests

Comments

@d-v-b
Copy link
Contributor

d-v-b commented Jan 3, 2025

Based on #2629 it seems that our test suite does not check group creation with mode=w. This probably means a test is not parametrized completely. This should be fixed.

@d-v-b d-v-b added good-first-issue Good place to get started as a new contributor. tests labels Jan 3, 2025
@dikwickley dikwickley linked a pull request Jan 12, 2025 that will close this issue
6 tasks
@dikwickley
Copy link

dikwickley commented Jan 12, 2025

@d-v-b added a pr for this.

@AdityaChaubeyIITM
Copy link

Hi, is this issue fixed? If not, I would like to work on it

@asimchoudhary asimchoudhary linked a pull request Feb 16, 2025 that will close this issue
6 tasks
@asimchoudhary
Copy link

Hii @d-v-b , i have opened the pr #2840 for the above issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Good place to get started as a new contributor. tests
Projects
None yet
4 participants