Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: migrate from CircleCI to Github Actions #1836
ci: migrate from CircleCI to Github Actions #1836
Changes from 10 commits
96f6960
eacdeb7
0c3ee46
e8c3827
d88f5df
28bdf5c
c824a85
03cb1a5
b7d41bb
d865963
6b17681
a149e1a
f2c080e
f566924
479f248
f6910c1
fd80114
40b06f3
7d18b05
f81f2f3
46f344a
00a4e8a
b5240e0
b8ce1dd
ded342c
8c82cc2
09a4dbf
41001b0
abf1547
02ffe95
eff3aee
2e07159
d89fbd8
7fd42cc
dbb478c
c480551
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these CI workflows should only happen on
pull_request
. That's the typical setting for all CircleCI repos. We just turned it off temporarily onreact-components
because there was no way to getnext
to build in addition tomain
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this config/GHA now allow us to only build on PR for select branches? π€π»
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it supports it.
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#running-your-pull_request-workflow-based-on-the-head-or-base-branch-of-a-pull-request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we forego
name
throughout? We're accustomed to seeing commands in CI, and the name tends to hide that info under a section that has to be expanded to view. And similar to CCI, GH Actions that we depend on will provide their own.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better! β
https://github.com/zendeskgarden/react-components/actions/runs/9572822615/job/26393239082
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stores content of
packages/**/dist/
fortest
andpublish
jobs.To (hopefully π ) stay within the 500MB storage monthly allowance, we can explicitly set
retention-days
in the config:Ex:
Or globally define it from the settings page.
Which way do you prefer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something we had set previously for CCI? I didn't see an equivalent, so I could go either way. The config route does feel more obvious for us to easily grok in the future, but the settings live independent of commit history.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's definitely rely on the setting rather than specify here. I want to be able to control this outside the scope of a PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see this folded directly into
deploy
. We're not getting a ton of value here, and the new workflow could be simplified with:where (lint, test, deploy) run in parallel. Furthermore, it makes good sense to wait for a successful
build
before doing thedeploy
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and it's fast! π₯ π
On
main
, do we still want to deploy even iftest
&lint
have not passed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, good Q. No I don't think we do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we good with GitHub Pages deployments on
main
after June 30? https://docs.github.com/en/pages/quickstartThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some digging, I found no indications that gh-pages used by
deploy.mjs
will stop working past June 30th.As a precaution and to future-proof our workflow, we could set 2
deploy
jobs:deploy-branch
: runs whengithub.ref != 'refs/heads/main'
and deploys to Netlify usingdeploy.mjs
deploy-main
: runs whengithub.ref == 'refs/heads/main'
and deploys to gh-pages via actions/deploy-pages@v4.This can be implemented now but at the small cost of extra verbosity, or I can create a follow-up branch to apply the proposed changes only if
deploy.mjs
fails to run past the Github's deadline.Any recommendations?