Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(accordions): new light/dark mode colors #1850

Merged
merged 7 commits into from
Jul 12, 2024
Merged

feat(accordions): new light/dark mode colors #1850

merged 7 commits into from
Jul 12, 2024

Conversation

ze-flo
Copy link
Contributor

@ze-flo ze-flo commented Jul 9, 2024 •
edited
Loading

Description

  • Adds light / dark mode support to Accordion, Stepper, and Timeline

Detail

  • Adds light / dark mode support to Accordion, Stepper, and Timeline
  • Replaces prop names with transient props

Screenshot 2024-07-09 at 8 22 55 AM
Screenshot 2024-07-09 at 8 22 39 AM
Screenshot 2024-07-09 at 8 22 18 AM

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • ♿ tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

@ze-flo ze-flo requested a review from a team as a code owner July 9, 2024 18:23
@ze-flo
Copy link
Contributor Author

ze-flo commented Jul 11, 2024

Staging preview:

https://668f28eab12633a41c5b910a--zendeskgarden-react-components.netlify.app

geotrev
geotrev approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@geotrev geotrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ze-flo ze-flo requested review from steue and sieeeeeenna July 11, 2024 22:23
jzempel
jzempel reviewed Jul 12, 2024
View reviewed changes
Copy link
Member

@jzempel jzempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final update from me ... Can we update the description for ITimelineItemProps['surfaceColor'] in types/index.ts from

"Provides surface color for an icon placed on a non-white background"

to

"Provides surface color for an icon placed on a non-default background"

steue
steue approved these changes Jul 12, 2024
View reviewed changes
Copy link

@steue steue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all components look solid! thnx! 🔥 🚀

@ze-flo ze-flo merged commit 816c29f into next Jul 12, 2024
7 checks passed
@ze-flo ze-flo deleted the ze-flo/accordions-recolor branch July 12, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzempel jzempel jzempel approved these changes

@geotrev geotrev geotrev approved these changes

@steue steue steue approved these changes

@sieeeeeenna sieeeeeenna Awaiting requested review from sieeeeeenna

Assignees
No one assigned
Labels
PR: New Feature 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ze-flo @jzempel @geotrev @steue