Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net:http: Add config guard file system in HTTP server #86450

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

phb98
Copy link

@phb98 phb98 commented Feb 28, 2025

in http_server_http2.c, We do not check the availability of file system before using calling FS api. This PR will check
CONFIG_FILE_SYSTEM before using those FS API.

This PR attempts to fix #86443

Copy link
Contributor

@rlubos rlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, just some nits.
The commit title needs a space in the prefix, i.e . net: http:. And it's not needed to ident the commit body.

http_server_http2.c does not guard check if file system is available
or not before using file system api. This PR will add guard for that

Signed-off-by: bac phan <[email protected]>
@phb98 phb98 force-pushed the http_server_fs_guard branch from 9a97153 to 65efe06 Compare February 28, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: HTTP HTTP client/server support area: Networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP Server should not rely on File System
4 participants