-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
how to install/rebuilt zeromq for Electron-3.0.0 ? #279
Comments
It looks like the binding is abandoned. New versions have not been published for more than a year. The last version v4.6.0 depends on prebuild-install v2.2.2, which depends on node-abi v2.0.0, which does not support electron v3 as build target. You must manually bump node-abi to at least v2.4.4 |
nikolovp, thanks for your answer! So I just rolled back to Electron-v2, and zeromq works again. |
Instead of rolling back to Electron v2, better fork the binding, update the prebuild-install dev dependency to its latest version and publish the module to a private npm registry (if you have one) or to npmjs.com (better namespace it like @lianhub/zeromq or similar to avoid collisions). This is what I did so I can keep working with latest electron versions. There is an open pull request for upgrading prebuild-install (#275) but there is no one to accept it. |
Hi nikolovp, I followed your instructions:
But when I do "npm install jerry-zeromq --save-dev", I got WARNING:
Any hint? Thanks! |
The latest version of zeromq.js was shipped which includes binaries for electron 3. Upgrade to 5.0.0 when you get a chance. 😄 |
Cool, this will simplify our workflow. I have one extra question. What is the reason for requiring msbuild toolset v140 instead of letting node-gyp pick the toolset based on msvs_version? It would be nice to be able to build the binding from source with VS above v2015 when a new electron versions gets published, instead of depending on prebuilt binaries. |
I'd love for it to be able to build the binding from source with VS above v2015 and can't recall why it's pinned. Perhaps you can dig into the source, find out, and send over some patches? |
Thanks all you guys!
And my program runs perfect as expected!!! |
Cool, glad it works now |
I am having the same issue with electron 6.0.2 |
I installed Electron-3.0.0 and found that zeromq is not working anymore.
Then I run:
npm rebuild zeromq --runtime=electron --target=3.0.0
But it didn't solve the problem!
Anybody runs zeromq inside Electron-3.0.0 successfully?
Thanks!
The text was updated successfully, but these errors were encountered: