fixup! remove unused getter

zestia · Jan 24, 2025 · 18fb54b · 18fb54b
1 parent e984053
commit 18fb54b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## 17.2.0
+
+- Remove `return false` from `@onSelect` as a means to close the dropdown. Prefer using the dropdown API directly.
+
 ## 17.1.6
 
 - Change sorting algorithm again

diff --git a/README.md b/README.md
@@ -126,7 +126,7 @@ Required. Fired when a selection is made (that is, an option is clicked, or ente
 
 #### `@onSelect`
 
-Optional. Similar to `@onChange` but fires regardless as to whether the value changed or not. The return value controls whether or not the select box will close after the selection.
+Optional. Similar to `@onChange` but fires regardless as to whether the value changed or not.
 
 #### `@onSearch`
 

diff --git a/addon/components/select-box/index.gjs b/addon/components/select-box/index.gjs
@@ -427,9 +427,9 @@ export default class SelectBox extends Component {
   }
 
   _handleSelected() {
-    const close = this.args.onSelect?.(this.api) ?? this.canAutoClose;
+    this.args.onSelect?.(this.api);
 
-    if (close) {
+    if (this.canAutoClose) {
       this.dropdown.close(SELECTED);
     }
   }