Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid IsAbortRefunded == true when processAbort fails for reasons other than onAbort reverts #3649

Open
lumtis opened this issue Mar 5, 2025 · 0 comments
Open

Avoid IsAbortRefunded == true when processAbort fails for reasons other than onAbort reverts #3649

lumtis opened this issue Mar 5, 2025 · 0 comments
Labels
m:crosschain

Comments

@lumtis
Copy link
Member

lumtis commented Mar 5, 2025

Context: #3414 (comment)

If the processAbort fails for a reason different than onAbort revert, then IsAbortRefunded should not be set to true, it means that the abort process didn't send the fund back to the abortAddress

Currently it can happen if DepositZRC20 or getZRC20 functions fail, which is not supposed to happen, so this issue should never happen. However it still a discrepancy in the logic that should be fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
m:crosschain
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lumtis