Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mis-typed "onSwipeDone" prop. #1

Open
Therapychild opened this issue Apr 29, 2021 · 0 comments
Open

Mis-typed "onSwipeDone" prop. #1

Therapychild opened this issue Apr 29, 2021 · 0 comments

Comments

@Therapychild
Copy link

Therapychild commented Apr 29, 2021

First of all, Thank you for an amazing module! I absolutely love it!

On version 1.0.6, the "onSwipeDone" prop is typed with "function" and it should be "Function". The mis-type causes an error to appear when type-checking is on.

I would like to submit a pull request, but upon forking the project, I can only find the .js and .d.ts files. I cannot find the .tsx file to actually fix it. I am pretty new to forking and submitting pull requests, so I am not sure if this is normal. I just believe that if it is not fixed in the .tsx file, it will revert every time it is built? I am very open to instruction or information so that I can help.

Thank you again for all of your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant