From b2e9fe170709d85fc2196582e5599e3917eb27f4 Mon Sep 17 00:00:00 2001 From: aparajit-pratap Date: Fri, 1 Dec 2023 14:24:11 -0500 Subject: [PATCH 01/22] Fix Popup UI (#14668) * remove coreclr-ncalc references * fix popup * rename * cleanup * resize line column in popup --- .../Views/GuidedTour/RealTimeInfoWindow.xaml | 25 ++++++++++--------- .../GuidedTour/RealTimeInfoWindow.xaml.cs | 11 ++++++-- 2 files changed, 22 insertions(+), 14 deletions(-) diff --git a/src/DynamoCoreWpf/Views/GuidedTour/RealTimeInfoWindow.xaml b/src/DynamoCoreWpf/Views/GuidedTour/RealTimeInfoWindow.xaml index b0488f6ad3f..17e9801107a 100644 --- a/src/DynamoCoreWpf/Views/GuidedTour/RealTimeInfoWindow.xaml +++ b/src/DynamoCoreWpf/Views/GuidedTour/RealTimeInfoWindow.xaml @@ -1,12 +1,10 @@ - - + - + - - + + StrokeThickness="2"/> - - - \ No newline at end of file diff --git a/src/DynamoCoreWpf/Controls/GraphUpdateNotificationControl.xaml.cs b/src/DynamoCoreWpf/Controls/GraphUpdateNotificationControl.xaml.cs deleted file mode 100644 index 48a41467509..00000000000 --- a/src/DynamoCoreWpf/Controls/GraphUpdateNotificationControl.xaml.cs +++ /dev/null @@ -1,36 +0,0 @@ -using System.Windows; -using System.Windows.Controls; - -using Dynamo.Updates; -using Dynamo.Wpf.Utilities; - -namespace DynamoCore.UI.Controls -{ - /// - /// Interaction logic for GraphUpdateNotificationControl.xaml - /// - public partial class GraphUpdateNotificationControl : UserControl - { - public GraphUpdateNotificationControl() - { - InitializeComponent(); - InstallButton.Click += OnInstallButtonClicked; - } - - private void OnInstallButtonClicked(object sender, RoutedEventArgs e) - { - var um = DataContext as IUpdateManager; - if (um == null) return; - - var result = MessageBoxService.Show(Dynamo.Wpf.Properties.Resources.UpdateMessage, - Dynamo.Wpf.Properties.Resources.InstallMessageCaption, - MessageBoxButton.OKCancel, - MessageBoxImage.None); - - if (result == MessageBoxResult.OK) - { - um.QuitAndInstallUpdate(); - } - } - } -} \ No newline at end of file diff --git a/src/DynamoCoreWpf/DynamoCoreWpf.csproj b/src/DynamoCoreWpf/DynamoCoreWpf.csproj index a75c9236d12..bb5c06ad00f 100644 --- a/src/DynamoCoreWpf/DynamoCoreWpf.csproj +++ b/src/DynamoCoreWpf/DynamoCoreWpf.csproj @@ -319,9 +319,6 @@ - - GraphUpdateNotificationControl.xaml - ShortcutToolbar.xaml @@ -569,10 +566,6 @@ Designer MSBuild:Compile - - MSBuild:Compile - Designer - Designer Always diff --git a/src/DynamoCoreWpf/UI/Converters.cs b/src/DynamoCoreWpf/UI/Converters.cs index 56df2b6627b..6028ffb653e 100644 --- a/src/DynamoCoreWpf/UI/Converters.cs +++ b/src/DynamoCoreWpf/UI/Converters.cs @@ -2239,48 +2239,6 @@ public object ConvertBack(object value, Type targetType, object parameter, Cultu } } - public class IsUpdateAvailableToTextConverter : IValueConverter - { - public object Convert(object value, Type targetType, object parameter, CultureInfo culture) - { - var um = value as IUpdateManager; - if (um == null) - return Resources.AboutWindowCannotGetVersion; - - if (!um.IsUpdateAvailable) - return Resources.AboutWindowUpToDate; - - var latest = um.AvailableVersion; - - return latest != null ? latest.ToString() : Resources.AboutWindowCannotGetVersion; - } - - public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture) - { - return null; - } - } - - public class IsUpdateAvailableBrushConverter : IValueConverter - { - public object Convert(object value, Type targetType, object parameter, CultureInfo culture) - { - SolidColorBrush brush; - - brush = (bool)value - ? (SolidColorBrush) - SharedDictionaryManager.DynamoColorsAndBrushesDictionary["UpdateManagerUpdateAvailableBrush"] - : (SolidColorBrush)SharedDictionaryManager.DynamoColorsAndBrushesDictionary["UpdateManagerUpToDateBrush"]; - - return brush; - } - - public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture) - { - return null; - } - } - public class BinaryRadioButtonCheckedConverter : IValueConverter { public object Convert(object value, Type targetType, object parameter, diff --git a/src/DynamoCoreWpf/UI/Themes/Modern/DynamoColorsAndBrushes.xaml b/src/DynamoCoreWpf/UI/Themes/Modern/DynamoColorsAndBrushes.xaml index 105ccbd5240..18edd8b4296 100644 --- a/src/DynamoCoreWpf/UI/Themes/Modern/DynamoColorsAndBrushes.xaml +++ b/src/DynamoCoreWpf/UI/Themes/Modern/DynamoColorsAndBrushes.xaml @@ -116,10 +116,6 @@ - - - - #000000 #000000 diff --git a/src/DynamoCoreWpf/UI/Themes/Modern/DynamoConverters.xaml b/src/DynamoCoreWpf/UI/Themes/Modern/DynamoConverters.xaml index 9b750dff15b..e244a6dea74 100644 --- a/src/DynamoCoreWpf/UI/Themes/Modern/DynamoConverters.xaml +++ b/src/DynamoCoreWpf/UI/Themes/Modern/DynamoConverters.xaml @@ -106,8 +106,6 @@ - - diff --git a/src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs b/src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs index 0583d55b413..5adaa99dbba 100644 --- a/src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs +++ b/src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs @@ -492,15 +492,6 @@ public string HostName get { return model.HostName; } } - public bool IsUpdateAvailable - { - get - { - var um = model.UpdateManager; - return um.IsUpdateAvailable; - } - } - public string LicenseFile { get @@ -728,7 +719,6 @@ protected DynamoViewModel(StartConfiguration startConfiguration) SubscribeModelUiEvents(); SubscribeModelChangedHandlers(); SubscribeModelBackupFileSaveEvent(); - SubscribeUpdateManagerHandlers(); InitializeAutomationSettings(startConfiguration.CommandFilePath); @@ -857,7 +847,6 @@ protected virtual void UnsubscribeAllEvents() UnsubscribeDispatcherEvents(); UnsubscribeModelUiEvents(); UnsubscribeModelChangedEvents(); - UnsubscribeUpdateManagerEvents(); UnsubscribeLoggerEvents(); UnsubscribeModelCleaningUpEvent(); UnsubscribeModelBackupFileSaveEvent(); @@ -892,16 +881,9 @@ private void UnsubscribeLoggerEvents() model.Logger.PropertyChanged -= Instance_PropertyChanged; } - private void SubscribeUpdateManagerHandlers() - { - model.UpdateManager.UpdateDownloaded += Instance_UpdateDownloaded; - model.UpdateManager.ShutdownRequested += UpdateManager_ShutdownRequested; - } - private void UnsubscribeUpdateManagerEvents() { - model.UpdateManager.UpdateDownloaded -= Instance_UpdateDownloaded; - model.UpdateManager.ShutdownRequested -= UpdateManager_ShutdownRequested; + } private void SubscribeModelUiEvents() @@ -1085,18 +1067,6 @@ internal bool CanClearLog(object parameter) return true; } - void Instance_UpdateDownloaded(object sender, UpdateDownloadedEventArgs e) - { - RaisePropertyChanged("Version"); - RaisePropertyChanged("IsUpdateAvailable"); - } - - void UpdateManager_ShutdownRequested(IUpdateManager updateManager) - { - PerformShutdownSequence(new ShutdownParams( - shutdownHost: true, allowCancellation: true)); - } - void CollectInfoManager_PropertyChanged(object sender, PropertyChangedEventArgs e) { switch (e.PropertyName) @@ -3475,11 +3445,6 @@ public bool PerformShutdownSequence(ShutdownParams shutdownParams) MainGuideManager?.CloseRealTimeInfoWindow(); model.ShutDown(shutdownParams.ShutdownHost); - if (shutdownParams.ShutdownHost) - { - model.UpdateManager.HostApplicationBeginQuit(); - } - UsageReportingManager.DestroyInstance(); this.model.CommandStarting -= OnModelCommandStarting; this.model.CommandCompleted -= OnModelCommandCompleted; diff --git a/src/DynamoCoreWpf/Views/About/AboutWindow.xaml b/src/DynamoCoreWpf/Views/About/AboutWindow.xaml index 9ff7236c0cf..008f85fb37e 100644 --- a/src/DynamoCoreWpf/Views/About/AboutWindow.xaml +++ b/src/DynamoCoreWpf/Views/About/AboutWindow.xaml @@ -1,4 +1,4 @@ - - - - + + + + - - - - + + + +