From 0e7af80f8a17c06cc15b1440048b70e78536fd20 Mon Sep 17 00:00:00 2001 From: Arseny Kapoulkine Date: Sat, 29 Apr 2023 10:57:28 -0700 Subject: [PATCH 1/2] Update versions of setup-node and upload-artifact This should fix build-time warnings on GHA about Node 12 deprecation. --- .github/workflows/build.yml | 4 ++-- .github/workflows/release.yml | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index a81760ea6..fb14adf1a 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -56,7 +56,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v1 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v3 with: node-version: '16' - name: test decoder @@ -93,7 +93,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v1 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v3 with: node-version: '14.x' - name: install wasi diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 04769cace..c86c8a226 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -25,12 +25,12 @@ jobs: run: cmake . -DMESHOPT_BUILD_GLTFPACK=ON -DMESHOPT_BASISU_PATH=basis_universal -DMESHOPT_WERROR=ON -DCMAKE_MSVC_RUNTIME_LIBRARY="MultiThreaded" -DCMAKE_BUILD_TYPE=Release - name: cmake build run: cmake --build . --target gltfpack --config Release -j 2 - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v3 with: name: gltfpack-windows path: Release/gltfpack.exe if: matrix.os == 'windows' - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v3 with: name: gltfpack-${{matrix.os}} path: gltfpack @@ -40,7 +40,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v1 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v3 with: node-version: '14.x' - name: install wasi @@ -61,11 +61,11 @@ jobs: cp LICENSE.md js/ cd gltf && npm pack && cd .. cd js && npm pack && cd .. - - uses: actions/upload-artifact@v2 + - uses: actions/upload-artifact@v3 with: name: gltfpack-npm path: gltf/gltfpack-*.tgz - - uses: actions/upload-artifact@v2 + - uses: actions/upload-artifact@v3 with: name: meshoptimizer-npm path: js/meshoptimizer-*.tgz From a2a431a1e3a84bfd01e70445b655359eb908e468 Mon Sep 17 00:00:00 2001 From: Arseny Kapoulkine Date: Sat, 29 Apr 2023 11:00:08 -0700 Subject: [PATCH 2/2] Also bump checkout@v2 to checkout@v3 (for some reason @v1 is fine?) --- .github/workflows/build.yml | 4 ++-- .github/workflows/release.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index fb14adf1a..19b8fdf1e 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -72,7 +72,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v1 - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: repository: KhronosGroup/glTF-Sample-Models path: glTF-Sample-Models @@ -121,7 +121,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v1 - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: repository: zeux/basis_universal ref: gltfpack diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index c86c8a226..33140a91b 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -16,7 +16,7 @@ jobs: runs-on: ${{matrix.os}}-latest steps: - uses: actions/checkout@v1 - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: repository: zeux/basis_universal ref: gltfpack