Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSA-PSS Warning #912

Open
Hagelkruys opened this issue Jan 29, 2025 · 3 comments
Open

RSA-PSS Warning #912

Hagelkruys opened this issue Jan 29, 2025 · 3 comments

Comments

@Hagelkruys
Copy link

Hello,

if parsing a certificate with RSASSA-PSS Signing Algorithm the zlint gives a warning "e_signature_algorithm_not_supported"

In "\v3\lints\cabf_br\lint_signature_algorithm_not_supported.go" it states the following.

// The BRs do not forbid the use of RSA-PSS as a signature scheme in
// certificates but it is not broadly supported by user-agents. Since
// the BRs do not forbid the practice we return a warning result.
// NOTE: The Mozilla root program policy *does* forbid their use since v2.7.
// This should be covered by a lint scoped to the Mozilla source instead of in
// this CABF lint.

That isn't correct anymore.

On the contrary, you should not use RSA with PKCS1v1.5 anymore, see https://www.bsi.bund.de/SharedDocs/Downloads/EN/BSI/Publications/TechGuidelines/TG02102/BSI-TR-02102-1.pdf?__blob=publicationFile&v=6 - 1.5 Dealing with Legacy Algorithms - RSA with PKCS1v1.5 padding

@zakird
Copy link
Member

zakird commented Jan 29, 2025

@Hagelkruys would you be willing to submit a PR to address this?

@Hagelkruys
Copy link
Author

I looked into creating an PR for this and found why the current implementation gives a warning for RSA-PSS.

In the referenced mozilla root program (v2.7) there was a change that RSA-PSS is not allowed as id in the SubjectPublicKeyInfo field, thats also in the current mozilla root program policy and BR.

CAs MUST NOT use the id-RSASSA-PSS OID (1.2.840.113549.1.1.10) within a SubjectPublicKeyInfo to represent an RSA key.

The linting file above checks for the SigningAlgorithm, that is another field. so there seams to be a mixup of SigningAlgorithm and SubjectPublicKeyInfo identifier

@Hagelkruys
Copy link
Author

I removed the warning and added the signature algorithm to the pass list.
PR ist here: #913

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants