Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-user-config action no longer copy parent directories #2059

Closed
TristanCacqueray opened this issue Dec 6, 2023 · 7 comments · Fixed by #2064
Closed

build-user-config action no longer copy parent directories #2059

TristanCacqueray opened this issue Dec 6, 2023 · 7 comments · Fixed by #2064

Comments

@TristanCacqueray
Copy link

It seems like since #1989 , config using https://github.com/urob/zmk-nodefree-config no longer build because of such errors:

 /tmp/tmp.vVFsbR0CcL/config/corne.keymap:17:10: fatal error: ../zmk-nodefree-config/keypos_def/keypos_42keys.h: No such file or directory
   17 | #include "../zmk-nodefree-config/keypos_def/keypos_42keys.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
TristanCacqueray added a commit to TristanCacqueray/zmk-config that referenced this issue Dec 6, 2023
@vvision
Copy link

vvision commented Dec 7, 2023

Reproduced on my side today too.

/tmp/tmp.UUyIFrP4xQ/config/splitkb_aurora_corne.keymap:13:10: fatal error: ../src/corne.dtsi: No such file or directory
   13 | #include "../src/corne.dtsi"
      |          ^~~~~~~~~~~~~~~~~~~

I'm also gonna pin the version of zmkfirmware/zmk/.github/workflows/build-user-config.yml.

vvision added a commit to vvision/zmk-config that referenced this issue Dec 7, 2023
@petejohanson
Copy link
Contributor

Can you give this a try?

https://github.com/petejohanson/revxlp-config/actions/runs/7132623640/workflow

Doing so will only copy if we detect the new Zephyr module bits, so we shouldn't break existing configs with that change. If it works for you I'll get this into a PR.

@ObiWanKeoni
Copy link

ObiWanKeoni commented Dec 7, 2023

@petejohanson that seems to work for my config! (I also use urob's zmk-nodefree-config)

@lou-bi
Copy link

lou-bi commented Dec 8, 2023

Hi, got this exact issue while building my firmware with Urob (not as a submodule).
I've follow your link @petejohanson , but Im not sure I did what I should. lou-bi/zmk-config@4b95d82#annotation_16243079431

What are we supposed to do with this build.yaml you linked ?

And will this be fixed in a later released ? Im more comfortable using default build params. For no reasons propably.

@ObiWanKeoni
Copy link

@lou-bi it looks like you've modified your build.yaml instead of your .github/build.yml, I think reverting your first change and applying Pete's fix will help move you along

And will this be fixed in a later released ? Im more comfortable using default build params. For no reasons propably.

Yep, assuming that's what @petejohanson referred to when saying "If it works for you I'll get this into a PR."

@caksoylar
Copy link
Contributor

You can also try moving the nodefree folder into config/ and refer to that path in the #include, I don't see a reason why that shouldn't work.

@lou-bi
Copy link

lou-bi commented Dec 8, 2023

@ObiWanKeoni , oh, that explain a lot of my previous trouble...
I can confirm too that @petejohanson 's fix did solve my issue !
Didn't try the @caksoylar one.

@petejohanson petejohanson linked a pull request Dec 8, 2023 that will close this issue
vvision added a commit to vvision/zmk-config that referenced this issue Jan 4, 2024
vvision added a commit to vvision/zmk-config that referenced this issue Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants