Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape special characters in URLs when title isn't parsed #40

Closed
Sanqui opened this issue Feb 1, 2022 · 4 comments
Closed

Escape special characters in URLs when title isn't parsed #40

Sanqui opened this issue Feb 1, 2022 · 4 comments

Comments

@Sanqui
Copy link

Sanqui commented Feb 1, 2022

When pasting a URL like https://twitter.com/_underscore, the plugin substitutes [https://twitter.com/_underscore](https://twitter.com/_underscore). The problem is Obisdian interprets the underscore as a Markdown character and renders the latter half of the link as italic. The plugin should escape characters like _ and * when putting raw URLs into titles.

@bugal
Copy link

bugal commented Jul 14, 2022

And also square brackets.

@wyne
Copy link

wyne commented Aug 2, 2022

I think an easy fix would be to use <a href="LINK">TITLE</a> instead of [TITLE](LINK) format.
Example: #53

@addshore
Copy link

Escaping could generally be improved I think
Using the following link
https://stackoverflow.com/questions/67379247/error-node-modules-types-jasmine-index-d-ts66815-error-ts2430-interface
Results in the following markdown
image

[angular - Error: node\_modules/@types/jasmine/index.d.ts:668:15 - error TS2430: Interface 'FunctionMatchers<Fn>' incorrectly extends interface 'Matchers<any>' - Stack Overflow](https://stackoverflow.com/questions/67379247/error-node-modules-types-jasmine-index-d-ts66815-error-ts2430-interface)

@zolrath
Copy link
Owner

zolrath commented Jan 4, 2024

This should be handled now! If there are any missing characters that should be escaped please let me know in another issue.
Thanks!

@zolrath zolrath closed this as completed Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants