From e4aba95ace8ac00d746d0fa6af0f9081624e0639 Mon Sep 17 00:00:00 2001 From: Sterling Hanenkamp Date: Thu, 13 Jul 2023 23:46:29 -0500 Subject: [PATCH] fix incomplete coverage --- Changes.md | 1 + generic/value_test.go | 2 ++ 2 files changed, 3 insertions(+) diff --git a/Changes.md b/Changes.md index e199fe5..c819182 100644 --- a/Changes.md +++ b/Changes.md @@ -2,6 +2,7 @@ WIP TBD * Added slices.FirstIndex and slices.GrepIndex. * Added set.NewSized and set.Diff. + * Fixed missing test coverage on generic.FirstNonNil and generic.FirstNonZero. v0.2.0 2023-07-08 diff --git a/generic/value_test.go b/generic/value_test.go index 115a2d3..c24d813 100644 --- a/generic/value_test.go +++ b/generic/value_test.go @@ -12,6 +12,7 @@ func TestFirstNonZero(t *testing.T) { assert.Equal(t, 1, generic.FirstNonZero[int](0, 1, 2)) assert.Equal(t, 1, generic.FirstNonZero[int](1, 0, 2)) assert.Equal(t, 1, generic.FirstNonZero[int](0, 0, 1)) + assert.Equal(t, 0, generic.FirstNonZero[int](0, 0, 0)) } func TestFirstNonNil(t *testing.T) { @@ -24,6 +25,7 @@ func TestFirstNonNil(t *testing.T) { assert.Equal(t, *b, *generic.FirstNonNil(a, b, c)) assert.Equal(t, *b, *generic.FirstNonNil(b, a, c)) assert.Equal(t, *b, *generic.FirstNonNil(a, a, b)) + assert.Nil(t, generic.FirstNonNil[int](nil, nil, nil)) } func TestZero(t *testing.T) {